You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "joan38 (GitHub)" <gi...@apache.org> on 2018/08/26 15:16:01 UTC
[GitHub] [kafka] joan38 opened pull request #5573: Correct folder for
package object scala
This package was not in the right folder compare to the package statement at the top of the file
[ Full content available at: https://github.com/apache/kafka/pull/5573 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kafka] joan38 commented on issue #5573: Correct folder for
package object scala
Posted by "joan38 (GitHub)" <gi...@apache.org>.
@vvcephei I just get a warning on Intellij Idea:
<img width="865" alt="screen shot 2018-08-27 at 21 46 08" src="https://user-images.githubusercontent.com/1200478/44685148-a655bb80-aa42-11e8-9e35-c2344298a0c6.png">
About the name of the file you are extremely right it should be `package.scala`. Good catch!
[ Full content available at: https://github.com/apache/kafka/pull/5573 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kafka] vvcephei commented on issue #5573: Correct folder
for package object scala
Posted by "vvcephei (GitHub)" <gi...@apache.org>.
Hey @joan38 ,
This exceeds my familiarity with scala. Can you link us to some documentation about where package objects should reside? The best doc I could find is from 2010, so I'm not sure if it's current, but it suggests that the package object should indeed be in the directory `org/apache/kafka/streams/scala/`, but that its file name should be `package.scala`.
https://www.scala-lang.org/docu/files/packageobjects/packageobjects.html
Thanks,
-John
[ Full content available at: https://github.com/apache/kafka/pull/5573 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kafka] joan38 commented on issue #5573: Correct folder for
package object scala
Posted by "joan38 (GitHub)" <gi...@apache.org>.
@vvcephei I just get a warning on Intellij Idea:
<img width="865" alt="screen shot 2018-08-27 at 21 46 08" src="https://user-images.githubusercontent.com/1200478/44685148-a655bb80-aa42-11e8-9e35-c2344298a0c6.png">
[ Full content available at: https://github.com/apache/kafka/pull/5573 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kafka] vvcephei commented on issue #5573: Correct folder
for package object scala
Posted by "vvcephei (GitHub)" <gi...@apache.org>.
Ah, ok! Actually, I was only concerned about the file name. Your dir name looked right to me. Sorry for the confusion.
@guozhangwang, this looks good to me.
[ Full content available at: https://github.com/apache/kafka/pull/5573 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kafka] guozhangwang closed pull request #5573: Correct
folder for package object scala
Posted by "guozhangwang (GitHub)" <gi...@apache.org>.
[ pull request closed by guozhangwang ]
[ Full content available at: https://github.com/apache/kafka/pull/5573 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kafka] joan38 commented on issue #5573: Correct folder for
package object scala
Posted by "joan38 (GitHub)" <gi...@apache.org>.
@vvcephei I just get a warning on Intellij Idea:
<img width="865" alt="screen shot 2018-08-27 at 21 46 08" src="https://user-images.githubusercontent.com/1200478/44685148-a655bb80-aa42-11e8-9e35-c2344298a0c6.png">
About the name of the file you are extremely right, it should be `package.scala`. Good catch!
[ Full content available at: https://github.com/apache/kafka/pull/5573 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org