You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ja...@apache.org on 2014/10/27 21:35:27 UTC

svn commit: r1634680 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel: PDDocument.java PDPageTree.java

Author: jahewson
Date: Mon Oct 27 20:35:27 2014
New Revision: 1634680

URL: http://svn.apache.org/r1634680
Log:
PDFBOX-2423: Change type of getCount() as suggested by Maruan

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java?rev=1634680&r1=1634679&r2=1634680&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java Mon Oct 27 20:35:27 2014
@@ -181,7 +181,7 @@ public class PDDocument implements Close
 
         // Get the first page
         PDDocumentCatalog catalog = getDocumentCatalog();
-        int pageCount = (int)catalog.getPages().getCount();
+        int pageCount = catalog.getPages().getCount();
         if (pageCount == 0)
         {
             throw new IllegalStateException("Cannot sign an empty document");
@@ -1225,7 +1225,7 @@ public class PDDocument implements Close
      */
     public int getNumberOfPages()
     {
-        return (int)getDocumentCatalog().getPages().getCount();
+        return getDocumentCatalog().getPages().getCount();
     }
 
     /**

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java?rev=1634680&r1=1634679&r2=1634680&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java Mon Oct 27 20:35:27 2014
@@ -280,7 +280,7 @@ public class PDPageTree implements COSOb
      * Returns the number of leaf nodes (page objects) that are descendants of this root within the
      * page tree.
      */
-    public long getCount() // todo: make this an 'int'? What is the page limit?
+    public int getCount()
     {
         return root.getInt(COSName.COUNT, 0);
     }