[PR] fix(desktop): apply the chosen app icon on the Windows taskbar [maka]

["shengfuandqin-stack (via GitHub)" <gi...@apache.org>]

shengfuandqin-stack opened a new pull request, #5102:
URL: https://github.com/apache/maka/pull/5102

   ## Summary
   
   Settings can show the classic mascot selected while the Windows taskbar keeps the packaged `sky` tile. The picker write succeeds; the OS surface does not.
   
   Windows `WM_SETICON` wants a small (16) and large (32) HICON, and Chromium groups the running window with the `.exe` shortcut unless a stable AppUserModelID is set. Handing `BrowserWindow.setIcon` the 1024px PNG master is a valid NativeImage, but it does not replace that packaged resource.
   
   - rebuild the running icon as a multi-size ICO (`16/24/32/48/64/256`) before `setIcon` and window creation
   - stamp `com.maka.desktop` / `com.maka.desktop.dev` before `ready`
   - leave the packaged `.exe` icon as `sky`; Finder/shortcut still cannot follow a live choice
   
   Refs #3431 #3941
   
   ## Verification
   
   - `npx biome check --write` on the seven changed files — no fixes applied
   - `npm --workspace @maka/desktop run build:main` — pass
   - `node --test --test-force-exit apps/desktop/dist/main/__tests__/app-icon.test.js apps/desktop/dist/main/__tests__/client-settings-effects.test.js` — 12 pass, including the new ICO-frame contract
   - `node --test --test-force-exit apps/desktop/dist/main/__tests__/startup-progress-window.test.js` — 7 pass
   
   Not run: packaged Windows installer (`electron-builder`) and a live taskbar capture against a signed `.exe`. The husky pre-commit Biome stdin hook failed to spawn `biome.cmd` on this Windows shell (`EINVAL`); Biome was run directly on the files instead.
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Grok — located the Windows `setIcon` / AppUserModelID gap, wrote the ICO rebuild, tests, and this PR under my direction.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] fix(desktop): apply the chosen app icon on the Windows taskbar [maka]

["shengfuandqin-stack (via GitHub)" <gi...@apache.org>]

shengfuandqin-stack closed pull request #5102: fix(desktop): apply the chosen app icon on the Windows taskbar
URL: https://github.com/apache/maka/pull/5102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org