You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/07/14 15:44:30 UTC
[GitHub] [spark] wangyum opened a new pull request, #42006: [SPARK-44429][SQL][TESTS] Make `MsSqlServerIntegrationSuite` robust in ANSI mode
wangyum opened a new pull request, #42006:
URL: https://github.com/apache/spark/pull/42006
### What changes were proposed in this pull request?
This PR changes the filter condition from `col("c") === 0` to `!col("c")` in `MsSqlServerIntegrationSuite` to avoid `AnalysisException` when ANSI is enabled by default. The root cause is that `AnsiTypeCoercion` does not contain [`BooleanEquality`](https://github.com/apache/spark/blob/618b52097c07105d734aaf9b2a22b372920b3f31/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala#L842).
### Why are the changes needed?
Make `MsSqlServerIntegrationSuite` robust in ANSI mode. This test has nothing to do with whether ANSI is enabled or not.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
N/A.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42006: [SPARK-44429][SQL][TESTS] Make `MsSqlServerIntegrationSuite` robust in ANSI mode
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42006:
URL: https://github.com/apache/spark/pull/42006#issuecomment-1637313946
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #42006: [SPARK-44429][SQL][TESTS] Make `MsSqlServerIntegrationSuite` robust in ANSI mode
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42006: [SPARK-44429][SQL][TESTS] Make `MsSqlServerIntegrationSuite` robust in ANSI mode
URL: https://github.com/apache/spark/pull/42006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org