You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/05/01 04:41:47 UTC
[GitHub] [commons-collections] samabcde opened a new pull request, #306: [COLLECTIONS-812] fix flaky test due to timestamp comment inserted in…
samabcde opened a new pull request, #306:
URL: https://github.com/apache/commons-collections/pull/306
… Properties methods.
- A comment line is inserted after the comment given when using [Properties#save(OutputStream, String)](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Properties.html#save(java.io.OutputStream,java.lang.String)), [Properties#store(OutputStream, String)](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Properties.html#store(java.io.OutputStream,java.lang.String)) and [Properties#store(Writer, String)](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Properties.html#store(java.io.Writer,java.lang.String))
e.g.`#Sat Apr 30 22:00:30 HKT 2022`. Hence the test will fail when actual, expected content are not written in same second. To fix the problem, comparison will ignore this comment
- Remove unnecessary `throws IOException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] samabcde closed pull request #306: [COLLECTIONS-812] fix flaky test due to timestamp comment inserted in…
Posted by GitBox <gi...@apache.org>.
samabcde closed pull request #306: [COLLECTIONS-812] fix flaky test due to timestamp comment inserted in…
URL: https://github.com/apache/commons-collections/pull/306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] samabcde commented on pull request #306: [COLLECTIONS-812] fix flaky test due to timestamp comment inserted in…
Posted by GitBox <gi...@apache.org>.
samabcde commented on PR #306:
URL: https://github.com/apache/commons-collections/pull/306#issuecomment-1117395706
@kinow , see your fix after I completed this, so I will close this PR. But please help to fix `testStoreToPrintWriter()` and `testSetProperty()` which are also using `Properties#store` and hence are also flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org