[GitHub] [superset] dpgaspar commented on a diff in pull request #24359: chore: remove deprecated apis estimate_query_cost, results, sql_json, csv

["dpgaspar (via GitHub)" <gi...@apache.org>]

dpgaspar commented on code in PR #24359:
URL: https://github.com/apache/superset/pull/24359#discussion_r1227589085


##########
superset/security/manager.py:
##########
@@ -713,6 +712,7 @@ def create_custom_permissions(self) -> None:
         self.add_permission_view_menu("all_datasource_access", "all_datasource_access")
         self.add_permission_view_menu("all_database_access", "all_database_access")
         self.add_permission_view_menu("all_query_access", "all_query_access")
+        self.add_permission_view_menu("can_csv", "Superset")

Review Comment:
   This is going to be a custom permissions now. I think that something like `can_download_chart` would make more sense, so I propose we do that as a fast follow.
   
   Another alternative is to totally remove this permission, since a user that can download a CSV, XLS related with a chart already as access to that chart data. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org