You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "stankiewicz (via GitHub)" <gi...@apache.org> on 2025/12/05 14:58:05 UTC
[PR] [Drain] TimerData causedByDrain field [beam]
stankiewicz opened a new pull request, #37009:
URL: https://github.com/apache/beam/pull/37009
This is PR is adding new field to TimerData. Noop for most of implementation apart from runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java that propagates draining information to TimerData.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Drain] TimerData causedByDrain field [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles merged PR #37009:
URL: https://github.com/apache/beam/pull/37009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Drain] TimerData causedByDrain field [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #37009:
URL: https://github.com/apache/beam/pull/37009#discussion_r2765834617
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/TimerInternals.java:
##########
@@ -211,19 +218,48 @@ public static TimerData of(
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
- TimeDomain domain) {
+ TimeDomain domain,
+ CausedByDrain causedByDrain) {
Review Comment:
Because of how this object was previously constructed, this broke: https://github.com/apache/beam/actions/runs/21685692093/job/62531968855
This is because previously, if you had 5 arguments, they resolved to this function, with ordered arguments:
String timerId,
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
TimeDomain domain
after this change, if you have 5 arguments they resolve to a function below with arguments:
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
TimeDomain domain,
CausedByDrain causedByDrain
This is just an internal change, but given how many callers there are, we may have been better off preserving the previous ordering guarantees.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Drain] TimerData causedByDrain field [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #37009:
URL: https://github.com/apache/beam/pull/37009#issuecomment-3618017417
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Drain] TimerData causedByDrain field [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #37009:
URL: https://github.com/apache/beam/pull/37009#discussion_r2765849506
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/TimerInternals.java:
##########
@@ -211,19 +218,48 @@ public static TimerData of(
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
- TimeDomain domain) {
+ TimeDomain domain,
+ CausedByDrain causedByDrain) {
Review Comment:
Oh I see, its because the checks ran a few months ago and probably the repo has shifted significantly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Drain] TimerData causedByDrain field [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #37009:
URL: https://github.com/apache/beam/pull/37009#issuecomment-3617262575
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Drain] TimerData causedByDrain field [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37009:
URL: https://github.com/apache/beam/pull/37009#issuecomment-3617263469
## Summary of Changes
Hello @stankiewicz, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a significant enhancement to the Apache Beam `TimerData` structure by adding a `causedByDrain` boolean field. This new field is designed to provide crucial context, allowing the system to differentiate between timers that are fired as part of a normal pipeline execution and those specifically triggered due to a draining operation. While the `TimerData` definition is updated globally, the specific logic for propagating the draining status is primarily implemented within the Dataflow worker's `WindmillTimerInternals`, with other timer instantiations defaulting to `false`. This change lays the groundwork for more robust and nuanced handling of timers during pipeline draining scenarios.
### Highlights
* **New Field in TimerData**: A new boolean field, `causedByDrain`, has been added to the `TimerData` class. This field indicates whether a timer was triggered as a result of a draining operation.
* **Dataflow Worker Integration**: The `WindmillTimerInternals` in the Dataflow worker (runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java) has been updated to propagate the actual draining status to the new `causedByDrain` field when creating `TimerData` instances.
* **Default Behavior for Existing Timers**: For most other existing timer creation sites across the codebase, the `causedByDrain` field is explicitly set to `false`, ensuring backward compatibility and a clear default value where draining status is not yet relevant or propagated.
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Drain] TimerData causedByDrain field [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #37009:
URL: https://github.com/apache/beam/pull/37009#discussion_r2765844627
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/TimerInternals.java:
##########
@@ -211,19 +218,48 @@ public static TimerData of(
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
- TimeDomain domain) {
+ TimeDomain domain,
+ CausedByDrain causedByDrain) {
Review Comment:
https://github.com/apache/beam/pull/37505 should fix. I'm confused why this didn't fail checks on this pr... That seems like the real problem here
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/TimerInternals.java:
##########
@@ -211,19 +218,48 @@ public static TimerData of(
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
- TimeDomain domain) {
+ TimeDomain domain,
+ CausedByDrain causedByDrain) {
Review Comment:
Because of how this object was previously constructed, this broke: https://github.com/apache/beam/actions/runs/21685692093/job/62531968855
This is because previously, if you had 5 arguments, they resolved to this function, with ordered arguments:
```
String timerId,
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
TimeDomain domain
```
after this change, if you have 5 arguments they resolve to a function below with arguments:
```
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
TimeDomain domain,
CausedByDrain causedByDrain
```
This is just an internal change, but given how many callers there are, we may have been better off preserving the previous ordering guarantees.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Drain] TimerData causedByDrain field [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37009:
URL: https://github.com/apache/beam/pull/37009#issuecomment-3617266312
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Drain] TimerData causedByDrain field [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #37009:
URL: https://github.com/apache/beam/pull/37009#issuecomment-3686722844
@kennknowles added enum. will make it green now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org