You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/20 06:20:46 UTC
[GitHub] [superset] pkdotson opened a new pull request #18102: fix: nativefilter dropdown on scroll
pkdotson opened a new pull request #18102:
URL: https://github.com/apache/superset/pull/18102
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This pr fixes an issue when user clicks on nativefilter select and when users scrolls it causes the filter dropdown to move on scroll. This pr moves the dropdown to the parent container using a ref instead of on the page.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
https://user-images.githubusercontent.com/17326228/150284399-3c990a64-14d9-4422-bc76-6a284bb9684b.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a change in pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #18102:
URL: https://github.com/apache/superset/pull/18102#discussion_r793088623
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -271,6 +277,7 @@ const Select = ({
ariaLabel,
fetchOnlyOnSearch,
filterOption = true,
+ getPopupContainer,
Review comment:
put this on top of `filterOption`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1020351225
One contingent issue that is appearing with these changes is that sometimes the dropdown is not fully visible and you won't be able to scroll the container down either, as you can see in the video.
https://user-images.githubusercontent.com/60598000/150832920-a69dc359-0fa9-458f-8187-d8b3f9756126.mp4
This is not necessarily worst than the previous behavior just pointing it out for visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson closed pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
pkdotson closed pull request #18102:
URL: https://github.com/apache/superset/pull/18102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #18102:
URL: https://github.com/apache/superset/pull/18102#discussion_r790618794
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -89,6 +89,12 @@ export interface SelectProps extends PickedSelectProps {
* False by default.
* */
allowNewOptions?: boolean;
+ /**
Review comment:
This comment should be generic. When you say something like `to prevent dropdown movement onscroll` you are limiting its uses.
You could use the Ant Design docs for this prop:
> Parent Node to which the selector should be rendered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1020351225
One contingent issue that is appearing with these changes is that sometimes the dropdown is not fully visible and you won't be able to scroll the container down either, as you can see in the video.
https://user-images.githubusercontent.com/60598000/150832920-a69dc359-0fa9-458f-8187-d8b3f9756126.mp4
This is not necessarily worst than the previous behavior just pointing it out for visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1082527421
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1018805226
# [Codecov](https://codecov.io/gh/apache/superset/pull/18102?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18102](https://codecov.io/gh/apache/superset/pull/18102?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db04b6c) into [master](https://codecov.io/gh/apache/superset/commit/5da3c45fc64b27d0f732cc9e26bf24f1ef9afa90?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5da3c45) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/18102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18102 +/- ##
==========================================
- Coverage 66.34% 66.34% -0.01%
==========================================
Files 1569 1569
Lines 61687 61688 +1
Branches 6241 6243 +2
==========================================
- Hits 40927 40926 -1
+ Misses 19162 19161 -1
- Partials 1598 1601 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.91% <80.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `48.33% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `77.14% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `69.01% <0.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `90.90% <ø> (ø)` | |
| [...es/superset-ui-core/src/chart/models/ChartProps.ts](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY2hhcnQvbW9kZWxzL0NoYXJ0UHJvcHMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `86.59% <100.00%> (ø)` | |
| [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `82.72% <100.00%> (+0.15%)` | :arrow_up: |
| [...d/src/SqlLab/components/SqlEditorLeftBar/index.jsx](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIvaW5kZXguanN4) | `54.28% <0.00%> (-1.27%)` | :arrow_down: |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `51.14% <0.00%> (-0.62%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.39% <0.00%> (-0.48%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/18102/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18102?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18102?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5da3c45...db04b6c](https://codecov.io/gh/apache/superset/pull/18102?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido edited a comment on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
geido edited a comment on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1020351225
One contingent issue that is appearing with these changes is that sometimes the dropdown is not fully visible and you won't be able to scroll the container down either, as you can see in the video.
https://user-images.githubusercontent.com/60598000/150832920-a69dc359-0fa9-458f-8187-d8b3f9756126.mp4
Before you could still scroll the dashboard container (right side) and the dropdown menu would move with it, basically making it visible. This change is not necessarily worst than the previous behavior just pointing it out for visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1020302573
@geido Ephemeral environment spinning up at http://54.214.130.185:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1020300730
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido edited a comment on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
geido edited a comment on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1020351225
One contingent issue that is appearing with these changes is that sometimes the dropdown is not fully visible and you won't be able to scroll the container down either, as you can see in the video.
https://user-images.githubusercontent.com/60598000/150832920-a69dc359-0fa9-458f-8187-d8b3f9756126.mp4
Before you could still scroll the dashboard container (right side) and the dropdown menu would move with it, basically making it visible. This change is not necessarily worst than the previous behavior just pointing it out for visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1017369144
@pkdotson Can you post the before video as well?
One tip: If you leave a blank line between the `after` word and the video link then the video is automatically loaded in the PR description. Like this:
After:
(blank_line)
`<video_link>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18102: fix: nativefilter dropdown on scroll
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18102:
URL: https://github.com/apache/superset/pull/18102#issuecomment-1018549684
Hey @pkdotson if you can fix the CI we should spin up a testenv. This approach has been proven problematic in the past and I think we need to go deep into testing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org