You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/01/26 22:28:39 UTC
[PR] fixes periodic failure with CompactionIT [accumulo]
keith-turner opened a new pull request, #4201:
URL: https://github.com/apache/accumulo/pull/4201
The test CompactionIT.testConcurrentSplit() would periodically fail because it relied on the old behavior of WaitFor. Changed the test to use custom code that waits up to three seconds for a condition to be met and then continues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixes periodic failure with CompactionIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #4201:
URL: https://github.com/apache/accumulo/pull/4201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixes periodic failure with CompactionIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4201:
URL: https://github.com/apache/accumulo/pull/4201#discussion_r1473732826
##########
test/src/main/java/org/apache/accumulo/test/functional/CompactionIT.java:
##########
@@ -474,10 +474,12 @@ public void testConcurrentSplit() throws Exception {
// wait a bit for some tablets to have files selected, it possible the compaction have
// completed before this so do not wait long
- Wait.waitFor(
- () -> countTablets(tableName, tabletMetadata -> tabletMetadata.getSelectedFiles() != null)
- > 0,
- 3000, 10);
+ long startTime = System.nanoTime();
Review Comment:
Updated in 8a71feb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fixes periodic failure with CompactionIT [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on code in PR #4201:
URL: https://github.com/apache/accumulo/pull/4201#discussion_r1470322250
##########
test/src/main/java/org/apache/accumulo/test/functional/CompactionIT.java:
##########
@@ -474,10 +474,12 @@ public void testConcurrentSplit() throws Exception {
// wait a bit for some tablets to have files selected, it possible the compaction have
// completed before this so do not wait long
- Wait.waitFor(
- () -> countTablets(tableName, tabletMetadata -> tabletMetadata.getSelectedFiles() != null)
- > 0,
- 3000, 10);
+ long startTime = System.nanoTime();
Review Comment:
A comment here explaining why waitFor will not work could help prevent someone from seeing this and thinking that it could be converted back. (applies in two places)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org