You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/09 03:32:04 UTC

[GitHub] [dubbo-go] LaurenceLiZhixin opened a new issue #987: Graceful shutdown 执行的是baseInvoker的Destroy()并不是具体协议invoker 的Destroy()

LaurenceLiZhixin opened a new issue #987:
URL: https://github.com/apache/dubbo-go/issues/987


   <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
   
   -->
   
   
   **What happened**:
   shutdown时执行baseInvoker.Destory()
   
   **What you expected to happen**:
   shutdown时执行协议invoker.Destory()
   
   **How to reproduce it (as minimally and precisely as possible)**:
   在invoker链中一定有invoker并没有实现Destory函数，造成该函数直接降级为baseInvoker。
   
   **Anything else we need to know?**:
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] flycash commented on issue #987: Graceful shutdown 执行具体协议exporter 的Destroy()的函数混乱

Posted by GitBox <gi...@apache.org>.
flycash commented on issue #987:
URL: https://github.com/apache/dubbo-go/issues/987#issuecomment-761929289


   我的理解是，要先把注册上去的服务摘下来，也就是第一步，Unexport；其次是摧毁本地的registry实例，也就是断了注册和发现的过程；最后是摧毁protocol。


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on issue #987: Graceful shutdown 执行具体协议exporter 的Destroy()的函数混乱

Posted by GitBox <gi...@apache.org>.
zouyx commented on issue #987:
URL: https://github.com/apache/dubbo-go/issues/987#issuecomment-761962192


   any other problems?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #987: Graceful shutdown 执行具体协议exporter 的Destroy()的函数混乱

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on issue #987:
URL: https://github.com/apache/dubbo-go/issues/987#issuecomment-765251217


   No problem. Thanks
   
   > 我的理解是，要先把注册上去的服务摘下来，也就是第一步，Unexport；其次是摧毁本地的registry实例，也就是断了注册和发现的过程；最后是摧毁protocol。
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin closed issue #987: Graceful shutdown 执行具体协议exporter 的Destroy()的函数混乱

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin closed issue #987:
URL: https://github.com/apache/dubbo-go/issues/987


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org