You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Ralph Goers <ra...@dslextreme.com> on 2014/05/18 07:47:39 UTC
Re: svn commit: r1595502 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
Please revert this change. It now occasionally fails on my machine. The reason for the loop is to avoid those failures.
Ralph
On May 17, 2014, at 9:00 AM, rpopma@apache.org wrote:
> Author: rpopma
> Date: Sat May 17 16:00:06 2014
> New Revision: 1595502
>
> URL: http://svn.apache.org/r1595502
> Log:
> performance improvement: reduce to a single sleep() long enough to trigger a rollover (speedup from 11 to 2.3 seconds)
>
> Modified:
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
>
> Modified: logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java?rev=1595502&r1=1595501&r2=1595502&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java (original)
> +++ logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java Sat May 17 16:00:06 2014
> @@ -58,12 +58,10 @@ public class RollingAppenderTimeTest {
>
> @Test
> public void testAppender() throws Exception {
> - for (int i=0; i < 100; ++i) {
> - if (i % 11 == 0) {
> - Thread.sleep(1000);
> - }
> - logger.debug("This is test message number " + i);
> - }
> + logger.debug("This is test message number 1");
> + Thread.sleep(1500);
> + logger.debug("This is test message number 2");
> +
> final File dir = new File(DIR);
> assertTrue("Directory not created", dir.exists() && dir.listFiles().length > 0);
> final File[] files = dir.listFiles();
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1595502 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
Posted by Remko Popma <re...@gmail.com>.
Occasional failure is no good of course, sorry about that.
I disliked that the test loops for 10 seconds first, and only then checks
if rollover succeeded.
I made a more robust version now. I see you just committed something
similar, I'll add to that.
On Sun, May 18, 2014 at 2:47 PM, Ralph Goers <ra...@dslextreme.com>wrote:
> Please revert this change. It now occasionally fails on my machine. The
> reason for the loop is to avoid those failures.
>
> Ralph
>
> On May 17, 2014, at 9:00 AM, rpopma@apache.org wrote:
>
> > Author: rpopma
> > Date: Sat May 17 16:00:06 2014
> > New Revision: 1595502
> >
> > URL: http://svn.apache.org/r1595502
> > Log:
> > performance improvement: reduce to a single sleep() long enough to
> trigger a rollover (speedup from 11 to 2.3 seconds)
> >
> > Modified:
> >
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
> >
> > Modified:
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java?rev=1595502&r1=1595501&r2=1595502&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
> (original)
> > +++
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
> Sat May 17 16:00:06 2014
> > @@ -58,12 +58,10 @@ public class RollingAppenderTimeTest {
> >
> > @Test
> > public void testAppender() throws Exception {
> > - for (int i=0; i < 100; ++i) {
> > - if (i % 11 == 0) {
> > - Thread.sleep(1000);
> > - }
> > - logger.debug("This is test message number " + i);
> > - }
> > + logger.debug("This is test message number 1");
> > + Thread.sleep(1500);
> > + logger.debug("This is test message number 2");
> > +
> > final File dir = new File(DIR);
> > assertTrue("Directory not created", dir.exists() &&
> dir.listFiles().length > 0);
> > final File[] files = dir.listFiles();
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
Re: svn commit: r1595502 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
Posted by Remko Popma <re...@gmail.com>.
Interesting, I've spent some time in the internals of the rolling appender
but I didn't know that it only rolled over every 16 log events. I'll see if
I can find that in the code. (Strange that the tests worked on my machine,
oh well...)
Thanks for helping to fix the test.
On Sun, May 18, 2014 at 3:14 PM, Ralph Goers <ra...@dslextreme.com>wrote:
> Never mind. The way you modified the test it wasn’t forcing a rollover. A
> check for rollover is only performed once per every 16 log events. In
> addition, since the compression happens on a separate thread some time
> needs to be allowed to have that complete. I’ve fixed these problems so
> hopefully I won’t see failures any more.
>
> Ralph
>
> On May 17, 2014, at 11:01 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
> Here is how it fails.
>
> Running
> org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.523 sec
> <<< FAILURE! - in
> org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest
> testAppender(org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest)
> Time elapsed: 1.508 sec <<< FAILURE!
> java.lang.AssertionError: No compressed files found
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest.testAppender(RollingAppenderTimeTest.java:76)
>
> On May 17, 2014, at 10:47 PM, Ralph Goers <Ra...@dslextreme.com>
> wrote:
>
> Please revert this change. It now occasionally fails on my machine. The
> reason for the loop is to avoid those failures.
>
> Ralph
>
> On May 17, 2014, at 9:00 AM, rpopma@apache.org wrote:
>
> Author: rpopma
> Date: Sat May 17 16:00:06 2014
> New Revision: 1595502
>
> URL: http://svn.apache.org/r1595502
> Log:
> performance improvement: reduce to a single sleep() long enough to trigger
> a rollover (speedup from 11 to 2.3 seconds)
>
> Modified:
>
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
>
> Modified:
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
> URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java?rev=1595502&r1=1595501&r2=1595502&view=diff
>
> ==============================================================================
> ---
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
> (original)
> +++
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
> Sat May 17 16:00:06 2014
> @@ -58,12 +58,10 @@ public class RollingAppenderTimeTest {
>
> @Test
> public void testAppender() throws Exception {
> - for (int i=0; i < 100; ++i) {
> - if (i % 11 == 0) {
> - Thread.sleep(1000);
> - }
> - logger.debug("This is test message number " + i);
> - }
> + logger.debug("This is test message number 1");
> + Thread.sleep(1500);
> + logger.debug("This is test message number 2");
> +
> final File dir = new File(DIR);
> assertTrue("Directory not created", dir.exists() &&
> dir.listFiles().length > 0);
> final File[] files = dir.listFiles();
>
>
>
>
>
>
Re: svn commit: r1595502 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
Posted by Ralph Goers <ra...@dslextreme.com>.
Never mind. The way you modified the test it wasn’t forcing a rollover. A check for rollover is only performed once per every 16 log events. In addition, since the compression happens on a separate thread some time needs to be allowed to have that complete. I’ve fixed these problems so hopefully I won’t see failures any more.
Ralph
On May 17, 2014, at 11:01 PM, Ralph Goers <ra...@dslextreme.com> wrote:
> Here is how it fails.
>
> Running org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.523 sec <<< FAILURE! - in org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest
> testAppender(org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest) Time elapsed: 1.508 sec <<< FAILURE!
> java.lang.AssertionError: No compressed files found
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest.testAppender(RollingAppenderTimeTest.java:76)
>
> On May 17, 2014, at 10:47 PM, Ralph Goers <Ra...@dslextreme.com> wrote:
>
>> Please revert this change. It now occasionally fails on my machine. The reason for the loop is to avoid those failures.
>>
>> Ralph
>>
>> On May 17, 2014, at 9:00 AM, rpopma@apache.org wrote:
>>
>>> Author: rpopma
>>> Date: Sat May 17 16:00:06 2014
>>> New Revision: 1595502
>>>
>>> URL: http://svn.apache.org/r1595502
>>> Log:
>>> performance improvement: reduce to a single sleep() long enough to trigger a rollover (speedup from 11 to 2.3 seconds)
>>>
>>> Modified:
>>> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
>>>
>>> Modified: logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
>>> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java?rev=1595502&r1=1595501&r2=1595502&view=diff
>>> ==============================================================================
>>> --- logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java (original)
>>> +++ logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java Sat May 17 16:00:06 2014
>>> @@ -58,12 +58,10 @@ public class RollingAppenderTimeTest {
>>>
>>> @Test
>>> public void testAppender() throws Exception {
>>> - for (int i=0; i < 100; ++i) {
>>> - if (i % 11 == 0) {
>>> - Thread.sleep(1000);
>>> - }
>>> - logger.debug("This is test message number " + i);
>>> - }
>>> + logger.debug("This is test message number 1");
>>> + Thread.sleep(1500);
>>> + logger.debug("This is test message number 2");
>>> +
>>> final File dir = new File(DIR);
>>> assertTrue("Directory not created", dir.exists() && dir.listFiles().length > 0);
>>> final File[] files = dir.listFiles();
>>>
>>>
>>
>
Re: svn commit: r1595502 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
Posted by Ralph Goers <ra...@dslextreme.com>.
Here is how it fails.
Running org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.523 sec <<< FAILURE! - in org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest
testAppender(org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest) Time elapsed: 1.508 sec <<< FAILURE!
java.lang.AssertionError: No compressed files found
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.apache.logging.log4j.core.appender.rolling.RollingAppenderTimeTest.testAppender(RollingAppenderTimeTest.java:76)
On May 17, 2014, at 10:47 PM, Ralph Goers <Ra...@dslextreme.com> wrote:
> Please revert this change. It now occasionally fails on my machine. The reason for the loop is to avoid those failures.
>
> Ralph
>
> On May 17, 2014, at 9:00 AM, rpopma@apache.org wrote:
>
>> Author: rpopma
>> Date: Sat May 17 16:00:06 2014
>> New Revision: 1595502
>>
>> URL: http://svn.apache.org/r1595502
>> Log:
>> performance improvement: reduce to a single sleep() long enough to trigger a rollover (speedup from 11 to 2.3 seconds)
>>
>> Modified:
>> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
>>
>> Modified: logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
>> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java?rev=1595502&r1=1595501&r2=1595502&view=diff
>> ==============================================================================
>> --- logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java (original)
>> +++ logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java Sat May 17 16:00:06 2014
>> @@ -58,12 +58,10 @@ public class RollingAppenderTimeTest {
>>
>> @Test
>> public void testAppender() throws Exception {
>> - for (int i=0; i < 100; ++i) {
>> - if (i % 11 == 0) {
>> - Thread.sleep(1000);
>> - }
>> - logger.debug("This is test message number " + i);
>> - }
>> + logger.debug("This is test message number 1");
>> + Thread.sleep(1500);
>> + logger.debug("This is test message number 2");
>> +
>> final File dir = new File(DIR);
>> assertTrue("Directory not created", dir.exists() && dir.listFiles().length > 0);
>> final File[] files = dir.listFiles();
>>
>>
>