You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Davide Giannella (JIRA)" <ji...@apache.org> on 2016/05/10 13:19:12 UTC

[jira] [Comment Edited] (OAK-4349) Commands in oak-run should not implement NodeStore creation logic from scratch

    [ https://issues.apache.org/jira/browse/OAK-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278061#comment-15278061 ] 

Davide Giannella edited comment on OAK-4349 at 5/10/16 1:18 PM:
----------------------------------------------------------------

as by http://markmail.org/message/6rmufo7xqzoali2p it seems it's going
to be needed for other projects beside oak-run (ie oak-upgrade); maybe
it will be better to put this in something like oak-commons and export
it properly.

WDYT?

+1 for the approach anyway.




was (Author: edivad):
as by http://markmail.org/message/6rmufo7xqzoali2p it seems it's going
to be needed for other projects beside oak-run (ie oak-upgrade); maybe
it will be better to put this in something like oak-commons and export
it properly.

WDYT?



> Commands in oak-run should not implement NodeStore creation logic from scratch
> ------------------------------------------------------------------------------
>
>                 Key: OAK-4349
>                 URL: https://issues.apache.org/jira/browse/OAK-4349
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: run
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>         Attachments: OAK-4349-01.patch
>
>
> Many commands in oak-run implement the same logic over and over to create a {{NodeStore}} from command line arguments. I think it would be better to have this logic in a single  place and reuse it from every command.
> In OAK-4246 I proposed an approach based on URIs. Instead of specified command line arguments and flags, a connection to a specific backend could be specified using a URI with application specific schemas. On OAK-4246 I showed some examples specific to the {{SegmentNodeStore}}:
> - {{segment:///path/to/dir}} opens an "old style" segment store at the specified folder.
> - {{segment:tar:///path/to/dir}} opens a"new style" segment store at the specified folder.
> - {{segment:tar:///path/to/dir?mm=false}} opens a "new style" segment store at the specified folder and disables memory mapped files.
> A solution based on URIs can be extended to other {{NodeStore}} implementations by using other schemes like {{segment:mem}}, {{document:mongo}}, {{document:rdb}}, and so on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)