You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by vo...@apache.org on 2020/03/27 02:37:31 UTC

[rocketmq-client-cpp] branch master updated: [ISSUE #291] Use separate factory for trace producer of push consumer.

This is an automated email from the ASF dual-hosted git repository.

vongosling pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-client-cpp.git


The following commit(s) were added to refs/heads/master by this push:
     new 6171577  [ISSUE #291] Use separate factory for trace producer of push consumer.
6171577 is described below

commit 6171577ce90a974f285d286a8c7cc254935a3e03
Author: dinglei <li...@163.com>
AuthorDate: Fri Mar 27 10:37:24 2020 +0800

    [ISSUE #291] Use separate factory for trace producer of push consumer.
    
    fix(trace): use a separate factory for trace producer of push consumer.
---
 src/consumer/DefaultMQPushConsumerImpl.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/consumer/DefaultMQPushConsumerImpl.cpp b/src/consumer/DefaultMQPushConsumerImpl.cpp
index 40dc291..12fddd3 100644
--- a/src/consumer/DefaultMQPushConsumerImpl.cpp
+++ b/src/consumer/DefaultMQPushConsumerImpl.cpp
@@ -1100,7 +1100,7 @@ bool DefaultMQPushConsumerImpl::dealWithMessageTrace() {
 void DefaultMQPushConsumerImpl::createMessageTraceInnerProducer() {
   m_DefaultMQProducerImpl = std::make_shared<DefaultMQProducerImpl>(getGroupName());
   m_DefaultMQProducerImpl->setMessageTrace(false);
-  m_DefaultMQProducerImpl->setInstanceName(getInstanceName());
+  m_DefaultMQProducerImpl->setInstanceName("MESSAGE_TRACE_" + getInstanceName());
   const SessionCredentials& session = getSessionCredentials();
   m_DefaultMQProducerImpl->setSessionCredentials(session.getAccessKey(), session.getSecretKey(),
                                                  session.getAuthChannel());
@@ -1109,7 +1109,7 @@ void DefaultMQPushConsumerImpl::createMessageTraceInnerProducer() {
   }
   m_DefaultMQProducerImpl->setNameSpace(getNameSpace());
   // m_DefaultMQProducerImpl->setNamesrvDomain(getNamesrvDomain());
-  m_DefaultMQProducerImpl->start(false);
+  m_DefaultMQProducerImpl->start();
 }
 void DefaultMQPushConsumerImpl::shutdownMessageTraceInnerProducer() {
   if (!getMessageTrace()) {
@@ -1117,7 +1117,7 @@ void DefaultMQPushConsumerImpl::shutdownMessageTraceInnerProducer() {
   }
   if (m_DefaultMQProducerImpl) {
     LOG_INFO("Shutdown Message Trace Inner Producer In Consumer.");
-    m_DefaultMQProducerImpl->shutdown(false);
+    m_DefaultMQProducerImpl->shutdown();
   }
 }
 bool DefaultMQPushConsumerImpl::hasConsumeMessageHook() {