You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/09 11:20:56 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28169: [WIP][SQL] Speed
up dates reading in ORC
MaxGekk opened a new pull request #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611991226
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611679254
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121033/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611729879
**[Test build #121044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121044/testReport)** for PR 28169 at commit [`69bcf23`](https://github.com/apache/spark/commit/69bcf238406628bb999e59218c60a919c1726d95).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28169: [SPARK-31398][SQL] Speed
up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611677620
**[Test build #121033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121033/testReport)** for PR 28169 at commit [`69bcf23`](https://github.com/apache/spark/commit/69bcf238406628bb999e59218c60a919c1726d95).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611730448
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611868922
LGTM. Can you check the benchmark numbers with Spark 2.4? Just want to see how much perf regression we have in 3.0 after this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611815251
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121044/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28169: [SPARK-31398][SQL] Fix
perf regression of loading dates before 1582 year by non-vectorized ORC
reader
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28169: [SPARK-31398][SQL] Fix perf regression of loading dates before 1582 year by non-vectorized ORC reader
URL: https://github.com/apache/spark/pull/28169#issuecomment-612757611
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28169: [SPARK-31398][SQL] Speed
up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611607882
**[Test build #121030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121030/testReport)** for PR 28169 at commit [`168d64d`](https://github.com/apache/spark/commit/168d64d5295a13fb44ca5601c931b5caa2f279fe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611727292
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611679240
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611609031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121030/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611730457
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25735/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611814744
**[Test build #121044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121044/testReport)** for PR 28169 at commit [`69bcf23`](https://github.com/apache/spark/commit/69bcf238406628bb999e59218c60a919c1726d95).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611815251
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121044/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611609021
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28169: [SPARK-31398][SQL] Fix
regression of loading dates before 1582 year by non-vectorized ORC reader.
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28169: [SPARK-31398][SQL] Fix regression of loading dates before 1582 year by non-vectorized ORC reader.
URL: https://github.com/apache/spark/pull/28169#issuecomment-612643046
@cloud-fan @HyukjinKwon @dongjoon-hyun Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169: [WIP][SQL]
Speed up dates reading in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611525017
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611876712
> Can you check the benchmark numbers with Spark 2.4? Just want to see how much perf regression we have in 3.0 after this patch.
@cloud-fan To have comparable results, need to port:
1. NoOp datasource
2. Changes in Benchmark framework to save results to files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28169: [SPARK-31398][SQL] Speed
up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-612095188
**[Test build #121084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121084/testReport)** for PR 28169 at commit [`69bcf23`](https://github.com/apache/spark/commit/69bcf238406628bb999e59218c60a919c1726d95).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28169: [SPARK-31398][SQL] Speed
up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611533512
@cloud-fan @HyukjinKwon @dongjoon-hyun Please, have a look at the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28169: [WIP][SQL] Speed up
dates reading in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611477490
**[Test build #121030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121030/testReport)** for PR 28169 at commit [`168d64d`](https://github.com/apache/spark/commit/168d64d5295a13fb44ca5601c931b5caa2f279fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611477490
**[Test build #121030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121030/testReport)** for PR 28169 at commit [`168d64d`](https://github.com/apache/spark/commit/168d64d5295a13fb44ca5601c931b5caa2f279fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-612096107
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [WIP][SQL] Speed
up dates reading in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611525017
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-612096107
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [WIP][SQL] Speed
up dates reading in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611525026
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25724/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611991226
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk edited a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
MaxGekk edited a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-612206971
I ran the benchmark `DateTimeRebaseBenchmark` on 2.4.6-SNAPSHOT:
```
OpenJDK 64-Bit Server VM 1.8.0_242-8u242-b08-0ubuntu3~18.04-b08 on Linux 4.15.0-1063-aws
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
Load dates from ORC: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
after 1582, vec off 48169 48276 96 2.1 481.7 1.0X
after 1582, vec on 5375 5410 41 18.6 53.7 9.0X
before 1582, vec off 22353 22482 198 4.5 223.5 2.2X
before 1582, vec on 5474 5475 1 18.3 54.7 8.8X
```
Here is the PR https://github.com/MaxGekk/spark/pull/27.
- After 1582, it is **~4 times faster**
- Before 1582, it is **~2 times faster**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169: [WIP][SQL]
Speed up dates reading in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611477946
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28169: [SPARK-31398][SQL] Speed
up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611990858
**[Test build #121084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121084/testReport)** for PR 28169 at commit [`69bcf23`](https://github.com/apache/spark/commit/69bcf238406628bb999e59218c60a919c1726d95).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk edited a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
MaxGekk edited a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-612206971
I ran the benchmark `DateTimeRebaseBenchmark` on 2.4.6-SNAPSHOT (https://github.com/MaxGekk/spark/commit/965757572bd4bfd04d6f547a6094d9b2891b34d6):
```
OpenJDK 64-Bit Server VM 1.8.0_242-8u242-b08-0ubuntu3~18.04-b08 on Linux 4.15.0-1063-aws
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
Load dates from ORC: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
after 1582, vec off 48169 48276 96 2.1 481.7 1.0X
after 1582, vec on 5375 5410 41 18.6 53.7 9.0X
before 1582, vec off 22353 22482 198 4.5 223.5 2.2X
before 1582, vec on 5474 5475 1 18.3 54.7 8.8X
```
Here is the PR https://github.com/MaxGekk/spark/pull/27.
- After 1582, it is **~4 times faster**
- Before 1582, it is **~2 times faster**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611609021
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28169: [SPARK-31398][SQL]
Fix perf regression of loading dates before 1582 year by non-vectorized ORC
reader
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28169: [SPARK-31398][SQL] Fix perf regression of loading dates before 1582 year by non-vectorized ORC reader
URL: https://github.com/apache/spark/pull/28169
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611991228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25774/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611609031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121030/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611524433
**[Test build #121033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121033/testReport)** for PR 28169 at commit [`69bcf23`](https://github.com/apache/spark/commit/69bcf238406628bb999e59218c60a919c1726d95).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611730448
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611730457
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25735/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611679254
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121033/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [WIP][SQL] Speed
up dates reading in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611477946
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-612096119
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121084/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [WIP][SQL] Speed
up dates reading in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611477952
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25721/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-612187690
+1 for @cloud-fan 's comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611729879
**[Test build #121044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121044/testReport)** for PR 28169 at commit [`69bcf23`](https://github.com/apache/spark/commit/69bcf238406628bb999e59218c60a919c1726d95).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169: [WIP][SQL]
Speed up dates reading in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611525026
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25724/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28169: [WIP][SQL] Speed up
dates reading in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611524433
**[Test build #121033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121033/testReport)** for PR 28169 at commit [`69bcf23`](https://github.com/apache/spark/commit/69bcf238406628bb999e59218c60a919c1726d95).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611815247
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611989222
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611990858
**[Test build #121084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121084/testReport)** for PR 28169 at commit [`69bcf23`](https://github.com/apache/spark/commit/69bcf238406628bb999e59218c60a919c1726d95).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169:
[SPARK-31398][SQL] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611991228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25774/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169:
[SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL][test-hive1.2] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611815247
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28169: [WIP][SQL]
Speed up dates reading in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28169: [WIP][SQL] Speed up dates reading in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611477952
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25721/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611989161
1. we can use `df.queryExecution.toRdd.foreach`
2. we don't need to commit the benchmark result in 2.4, just need to take a look at the numbers and put it in PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-612096119
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121084/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28169: [SPARK-31398][SQL]
Speed up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-611679240
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28169: [SPARK-31398][SQL] Speed
up reading dates in ORC
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28169: [SPARK-31398][SQL] Speed up reading dates in ORC
URL: https://github.com/apache/spark/pull/28169#issuecomment-612206971
I ran the benchmark `DateTimeRebaseBenchmark` on 2.4.6-SNAPSHOT:
```
OpenJDK 64-Bit Server VM 1.8.0_242-8u242-b08-0ubuntu3~18.04-b08 on Linux 4.15.0-1063-aws
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
Load dates from ORC: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
after 1582, vec off 48169 48276 96 2.1 481.7 1.0X
after 1582, vec on 5375 5410 41 18.6 53.7 9.0X
before 1582, vec off 22353 22482 198 4.5 223.5 2.2X
before 1582, vec on 5474 5475 1 18.3 54.7 8.8X
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org