You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/08/16 10:09:43 UTC

[Impala-ASF-CR] [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

lipenglin@sensorsdata.cn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18854


Change subject: [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................

[IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0

Fix Impalad crashed in the method ParquetBoolDecoder::SkipValues when
the parameter 'num_values' is 0. In the method
ParquetBoolDecoder::SkipValues, if the parameter 'num_values' is 0
return true without other logic.

Testing:
 - Add e2e tests

Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
---
M be/src/exec/parquet/parquet-column-readers.cc
A testdata/workloads/functional-query/queries/QueryTest/parquet-page-index-bugfix.test
M tests/query_test/test_parquet_stats.py
3 files changed, 35 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/18854/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>

[Impala-ASF-CR] [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8448/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 11:43:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11174/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 03:25:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................

IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0

Fix Impalad crashed in the method ParquetBoolDecoder::SkipValues when
the parameter 'num_values' is 0. The function should tolerate that the
'num_values' is 0 values.

Testing:
 - Add e2e tests

Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
---
M be/src/exec/parquet/parquet-bool-decoder.cc
A testdata/workloads/functional-query/queries/QueryTest/parquet-page-index-bugfix.test
M tests/query_test/test_parquet_stats.py
3 files changed, 35 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/18854/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11179/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 10:41:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8459/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 03:43:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 16:24:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8462/


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 15:13:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 10:19:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18854/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18854/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-11500: F
> nit: you shouldn't use brackets, first line should be:
That is my mistakes! Subconsciously using the style of the company I work for.


http://gerrit.cloudera.org:8080/#/c/18854/1/be/src/exec/parquet/parquet-column-readers.cc
File be/src/exec/parquet/parquet-column-readers.cc:

http://gerrit.cloudera.org:8080/#/c/18854/1/be/src/exec/parquet/parquet-column-readers.cc@396
PS1, Line 396:   if (bool_decoder_) {
> Maybe the solution can be made a bit more future-proof if we make the bool 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 02:58:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................

IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0

Fix Impalad crashed in the method ParquetBoolDecoder::SkipValues when
the parameter 'num_values' is 0. The function should tolerate that the
'num_values' is 0 values.

Testing:
 - Add e2e tests

Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
---
M be/src/exec/parquet/parquet-bool-decoder.cc
A testdata/workloads/functional-query/queries/QueryTest/parquet-page-index-bugfix.test
M tests/query_test/test_parquet_stats.py
3 files changed, 35 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/18854/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 1:

(2 comments)

Thanks for working on this!

http://gerrit.cloudera.org:8080/#/c/18854/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18854/1//COMMIT_MSG@7
PS1, Line 7: [IMPALA-11500] 
nit: you shouldn't use brackets, first line should be:

IMPALA-11500:


http://gerrit.cloudera.org:8080/#/c/18854/1/be/src/exec/parquet/parquet-column-readers.cc
File be/src/exec/parquet/parquet-column-readers.cc:

http://gerrit.cloudera.org:8080/#/c/18854/1/be/src/exec/parquet/parquet-column-readers.cc@396
PS1, Line 396:   if (num_values == 0) return true;
Maybe the solution can be made a bit more future-proof if we make the bool decoder's SkipValues() function tolerate 0 values. So if we start using SkipValues() at other places we won't run into this crash again.

Actually I think it's already working fine in case of 0, we just need to change the initial DCHECK_GT to DCHECK_GE(num_values, 0);



-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 11:32:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8459/


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 08:30:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Aug 2022 07:31:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Thanks for fixing this!

http://gerrit.cloudera.org:8080/#/c/18854/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18854/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-11500: F
> That is my mistakes! Subconsciously using the style of the company I work f
No worries, this is also why we are doing code reviews :)



-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 10:19:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11173/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 03:18:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8462/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 10:19:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8469/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Aug 2022 02:42:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11161/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 10:30:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................

IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0

Fix Impalad crashed in the method ParquetBoolDecoder::SkipValues when
the parameter 'num_values' is 0. In the method
ParquetBoolDecoder::SkipValues, if the parameter 'num_values' is 0
return true without other logic.

Testing:
 - Add e2e tests

Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
---
M be/src/exec/parquet/parquet-bool-decoder.cc
A testdata/workloads/functional-query/queries/QueryTest/parquet-page-index-bugfix.test
M tests/query_test/test_parquet_stats.py
3 files changed, 35 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/18854/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18854 )

Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0
......................................................................

IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0

Fix Impalad crashed in the method ParquetBoolDecoder::SkipValues when
the parameter 'num_values' is 0. The function should tolerate that the
'num_values' is 0 values.

Testing:
 - Add e2e tests

Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Reviewed-on: http://gerrit.cloudera.org:8080/18854
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/parquet-bool-decoder.cc
A testdata/workloads/functional-query/queries/QueryTest/parquet-page-index-bugfix.test
M tests/query_test/test_parquet_stats.py
3 files changed, 35 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37
Gerrit-Change-Number: 18854
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>