You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/02 08:12:48 UTC

[GitHub] jh3507 commented on a change in pull request #1081: [CALCITE-2888] Enhance RexImplicationChecker to better handle cast

jh3507 commented on a change in pull request #1081: [CALCITE-2888] Enhance RexImplicationChecker to better handle cast
URL: https://github.com/apache/calcite/pull/1081#discussion_r261818732
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/VisitorDataContext.java
 ##########
 @@ -172,6 +196,20 @@ private static RexNode removeCast(RexNode inputRef) {
     }
     return inputRef;
   }
-}
 
+  private static RexNode convertAndRemoveCast(RexBuilder builder, RexExecutor executor,
+                                     RexNode literal, RelDataType toType) {
 
 Review comment:
   Thanks. Updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services