You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/11 12:33:00 UTC

[jira] [Commented] (SSHD-827) Dynamic port forwarding server closes session after first unsuccessful connection

    [ https://issues.apache.org/jira/browse/SSHD-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507967#comment-16507967 ] 

ASF GitHub Bot commented on SSHD-827:
-------------------------------------

GitHub user janwaros opened a pull request:

    https://github.com/apache/mina-sshd/pull/59

    [SSHD-827] Close immediately channels that were not opened due to exception

    Fix for SSHD-827

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/janwaros/mina-sshd master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mina-sshd/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #59
    
----
commit d38f4bb68064d57b980b42a01e2693c8c6cac35c
Author: jkoscinski <ja...@...>
Date:   2018-06-11T12:21:01Z

    Close immediately channels that were not opened due to exception

----


> Dynamic port forwarding server closes session after first unsuccessful connection
> ---------------------------------------------------------------------------------
>
>                 Key: SSHD-827
>                 URL: https://issues.apache.org/jira/browse/SSHD-827
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 1.6.0, 1.7.0, 2.0.0
>            Reporter: Jaroslaw Koscinski
>            Priority: Major
>             Fix For: 2.0.0
>
>         Attachments: close_immedietely.patch
>
>
> After first unsuccessful connection attempt through proxy dynamic port forwarding socket gets closed. How to reproduce:
>  # Setup dynamic port forwarding
>  # Try connecting to unreachable host through proxy
> The reason for this is because sshd tries to do graceful channel close on channel that hasn't been opened. After unsuccessful attempt to open forwading channel to unreachable host sshd sends SSH_MSG_CHANNEL_CLOSE to which SSH server responds with error and the whole session is going down (tested with SSH-2.0-OpenSSH_5.3).
> I've attached a patch with fix proposal. In my case that fixed the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)