You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/10/27 20:39:58 UTC
Review Request 27242: SQOOP-1605: Sqoop2: Misc From/to cleanups
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27242/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1605
https://issues.apache.org/jira/browse/SQOOP-1605
Repository: sqoop-sqoop2
Description
-------
commit e6c771da9bea0a6da60e10edc4684517c5a70e68
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Mon Oct 27 12:10:39 2014 -0700
SQOOP-1605: Sqoop2: Misc From/to cleanups
:100644 100644 e83002d... f6447c6... M core/src/main/java/org/apache/sqoop/driver/JobManager.java
:100644 100644 ae0e922... e11fd10... M core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
:100644 100644 21ff376... 61b1610... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 0d3d2b5... 6f136b2... M shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java
:100644 100644 646e8cb... 631ceca... M submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
Diffs
-----
core/src/main/java/org/apache/sqoop/driver/JobManager.java e83002d
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java ae0e922
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 21ff376
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java 0d3d2b5
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 646e8cb
Diff: https://reviews.apache.org/r/27242/diff/
Testing
-------
mvn clean verify -Dsqoop.hadoop.runner.class=org.apache.sqoop.test.hadoop.HadoopLocalRunner
Thanks,
Abraham Elmahrek
Re: Review Request 27242: SQOOP-1605: Sqoop2: Misc From/to cleanups
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27242/#review58666
-----------------------------------------------------------
Ship it!
yay! thanks for removing all the todo's!
core/src/main/java/org/apache/sqoop/driver/JobManager.java
<https://reviews.apache.org/r/27242/#comment99739>
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
<https://reviews.apache.org/r/27242/#comment99740>
Jarcec is taking care of this. so its ok to remove it I guess
- Veena Basavaraj
On Oct. 27, 2014, 12:39 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27242/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 12:39 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1605
> https://issues.apache.org/jira/browse/SQOOP-1605
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit e6c771da9bea0a6da60e10edc4684517c5a70e68
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Mon Oct 27 12:10:39 2014 -0700
>
> SQOOP-1605: Sqoop2: Misc From/to cleanups
>
> :100644 100644 e83002d... f6447c6... M core/src/main/java/org/apache/sqoop/driver/JobManager.java
> :100644 100644 ae0e922... e11fd10... M core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
> :100644 100644 21ff376... 61b1610... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 0d3d2b5... 6f136b2... M shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java
> :100644 100644 646e8cb... 631ceca... M submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/driver/JobManager.java e83002d
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java ae0e922
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 21ff376
> shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java 0d3d2b5
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 646e8cb
>
> Diff: https://reviews.apache.org/r/27242/diff/
>
>
> Testing
> -------
>
> mvn clean verify -Dsqoop.hadoop.runner.class=org.apache.sqoop.test.hadoop.HadoopLocalRunner
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 27242: SQOOP-1605: Sqoop2: Misc From/to cleanups
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27242/#review58669
-----------------------------------------------------------
Ship it!
[+1](http://www.lgtm.in/u/krJ1)
- Gwen Shapira
On Oct. 27, 2014, 7:39 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27242/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 7:39 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1605
> https://issues.apache.org/jira/browse/SQOOP-1605
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit e6c771da9bea0a6da60e10edc4684517c5a70e68
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Mon Oct 27 12:10:39 2014 -0700
>
> SQOOP-1605: Sqoop2: Misc From/to cleanups
>
> :100644 100644 e83002d... f6447c6... M core/src/main/java/org/apache/sqoop/driver/JobManager.java
> :100644 100644 ae0e922... e11fd10... M core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
> :100644 100644 21ff376... 61b1610... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 0d3d2b5... 6f136b2... M shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java
> :100644 100644 646e8cb... 631ceca... M submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/driver/JobManager.java e83002d
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java ae0e922
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 21ff376
> shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java 0d3d2b5
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 646e8cb
>
> Diff: https://reviews.apache.org/r/27242/diff/
>
>
> Testing
> -------
>
> mvn clean verify -Dsqoop.hadoop.runner.class=org.apache.sqoop.test.hadoop.HadoopLocalRunner
>
>
> Thanks,
>
> Abraham Elmahrek
>
>