You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2015/06/17 01:16:07 UTC
[GitHub] couchdb-fauxton pull request: Fix Sidebar links for view links
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/463
Fix Sidebar links for view links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton fix-sidebar-views
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #463
----
commit 6941128fa40e9d6ee7bf737faf8c81394ad3e5fa
Author: michellephung@gmail.com <mi...@gmail.com>
Date: 2015-06-16T18:52:28Z
Fix Sidebar links for view links
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix Sidebar links for view links
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/463#issuecomment-113781157
Hey @robertkowalski ! Welcome back!
It is a reasonable thing to be able to wonder.
When we moved the Fauxton code to a production environment such as a live site, the sidebar view links (the links listed under 'Views'), such as "myview" wouldn't redirect to the 'edit view page', as you would expect. Instead it would collapse the particular ddoc view menu, and you couldn't get to view results or edit the ddoc view.
Since I had been working on some of the conversion of the sidebar (although I think we should call it the "middle bar") to React, my first assumption was to fix the problem inside the React code, since I had been working with it for a couple weeks, and I had assumed it must have been part of the React conversion.
However, when I told @benkeen that something similar had happened a couple of months ago, where our development environment would behave differently than in a production environment, he decided to investigate further. He found that the url we were building each time for navigate wasn't working the same way in the two different environments, and a detail of his findings are documented here: https://github.com/apache/couchdb-fauxton/pull/465
I left this PR up, because
1.) It *is* a fix for the problem
2.) It's a reference, and history for what Ben's proposing
3.) it's nice to have different options
I think we should merge https://github.com/apache/couchdb-fauxton/pull/465, since it would solve potential link issues in the future, plus it'd be more intuitive for coders to have the local environment simulate more accurately the production environment, and not have to explicitly prevent bubbling up/down each time there is a link on the page that falls under this scenario.
I'll leave this up until we decide on which fix will be merged, (since I'm a huge fan of history!, and) since it's alternative option.
Although to reiterate: I think we should go with ben's pr#465
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix Sidebar links for view links
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix Sidebar links for view links
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/463#issuecomment-113673241
I'm sorry but I don't understand what it should fix, the only information I get is a "Fix Sidebar links for view links" and code where you are stopping the bubbling of an event. This is not meant to be mean, but I really have problems to understand what you are trying to solve, thus resulting in questions further questions for the review.
Can you please add a proper commit message and a unit test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---