You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/05 10:43:57 UTC

[GitHub] [arrow-datafusion] Dandandan commented on pull request #508: add expr::like and expr::notlike to pruning logic

Dandandan commented on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855220573


   > @alamb is it enough to add the `like` and `not like` where I added them? Not sure of where else I need to change.
   > 
   > @Dandandan I'm unable to configure the TPC benchmark data (rather, converting the files to Parquet).
   > 
   > If you don't mind, may you please check if Q{14|16|20} perform any better with this change? They use `like` and `not like` that can be pruned.
   
   I can try!
   In my experience / to my knowlegde pruning only matters on sorted / bucketed / colocated data. The data generated by the TPC-H benchmark is very well distributed by default without doing some kind of sorting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org