You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/30 06:52:03 UTC

[GitHub] [rocketmq] Stupid-Dird commented on pull request #3677: Feature/3676

Stupid-Dird commented on pull request #3677:
URL: https://github.com/apache/rocketmq/pull/3677#issuecomment-1002896262


   Yes, you need to call countDown () in the onSuccess () method, but it is not just this problem, but also remove the RequestResponseFuture object in RequestFutureTable.
   
   In the overloaded method, you need to call the onsuccess method of the incoming requestcallback. I have modified and initiated PR, and the link is as follows: https://github.com/apache/rocketmq/pull/3677
   
   
   
   是的，需要在onSuccess()方法中调用countDown(),但不仅仅是这个问题，还有移除RequestFutureTable中的RequestResponseFuture对象。
   在重载的方法中，需要对传入的RequestCallBack的onSuccess方法进行调用。我已经修改完成了发起了PR，链接如下：https://github.com/apache/rocketmq/pull/3677


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org