You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/22 12:32:22 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15298: [bugfix](from_unixtime) fix timezone not work for from_unixtime
github-actions[bot] commented on code in PR #15298:
URL: https://github.com/apache/doris/pull/15298#discussion_r1055412028
##########
be/src/gutil/casts.h:
##########
@@ -89,8 +90,8 @@ inline To down_cast(From* f) { // so we only accept pointers
// compiler will just bind From to const T.
template <typename To, typename From>
inline To down_cast(From& f) {
- COMPILE_ASSERT(base::is_reference<To>::value, target_type_not_a_reference);
- typedef typename base::remove_reference<To>::type* ToAsPointer;
+ COMPILE_ASSERT(std::is_reference<To>::value, target_type_not_a_reference);
+ typedef typename std::remove_reference<To>::type* ToAsPointer;
Review Comment:
warning: use 'using' instead of 'typedef' [modernize-use-using]
```suggestion
using ToAsPointer = typename std::remove_reference<To>::type *;
```
##########
be/src/gutil/once.h:
##########
@@ -64,7 +63,7 @@ inline void GoogleOnceInitArg(GoogleOnceType* state, void (*func_with_arg)(T*),
Atomic32 s = Acquire_Load(&state->state);
if (PREDICT_FALSE(s != GOOGLE_ONCE_INTERNAL_DONE)) {
// Deal with const T as well as non-const T.
- typedef typename base::remove_const<T>::type mutable_T;
+ typedef typename std::remove_const<T>::type mutable_T;
Review Comment:
warning: use 'using' instead of 'typedef' [modernize-use-using]
```suggestion
using mutable_T = typename std::remove_const<T>::type;
```
##########
be/src/gutil/once.h:
##########
@@ -102,7 +101,7 @@
Atomic32 s = Acquire_Load(&this->state_);
if (PREDICT_FALSE(s != GOOGLE_ONCE_INTERNAL_DONE)) {
// Deal with const T as well as non-const T.
- typedef typename base::remove_const<T>::type mutable_T;
+ typedef typename std::remove_const<T>::type mutable_T;
Review Comment:
warning: use 'using' instead of 'typedef' [modernize-use-using]
```suggestion
using mutable_T = typename std::remove_const<T>::type;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org