You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2013/11/08 09:48:13 UTC

Review Request 15344: Enabling DB HA for cloud stack data bases using mysql active-active solution

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15344/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Darren Shepherd.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4916
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4916


Repository: cloudstack-git


Description
-------

To enable Data base High Availability for cloud stack management server database. We have used Mysql's connector parameters to switch between master and slaves along with mysql's 2-way replication and chain way of replication for more than 2 nodes

https://wikis.oracle.com/display/CommSuite/MySQL+High+Availability+and+Replication+Information+For+Calendar+Server#MySQLHighAvailabilityandReplicationInformationForCalendarServer-MySQLServerTwoWayReplicationExample

Due ot this defect http://bugs.mysql.com/bug.php?id=68141 changed 2 files to have synchronized for on block of statements which were cauing Thread BLOCKING..


Diffs
-----

  client/tomcatconf/db.properties.in b0cb22b 
  framework/db/src/com/cloud/utils/db/ConnectionConcierge.java acb9cc6 
  framework/db/src/com/cloud/utils/db/Merovingian2.java 8544aab 
  framework/db/src/com/cloud/utils/db/TransactionLegacy.java a874ce1 

Diff: https://reviews.apache.org/r/15344/diff/


Testing
-------

Basic sanity testing is done using 2 nodes. If any transaction(api request) is in between and if server goes down then that api request will fail


Thanks,

Damodar Reddy Talakanti


Re: Review Request 15344: Enabling DB HA for cloud stack data bases using mysql active-active solution

Posted by Darren Shepherd <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15344/#review28545
-----------------------------------------------------------


I don't agree with this approach.  Following this logic for every possible option one would want to add to the jdbc url we would need to write code to manage it.  I would prefer that we just provide a way for the operator to fully override the URL.  So they just add "db.cloud.url=jdbc:.." to the db.properties and that will override the code generated url

- Darren Shepherd


On Nov. 8, 2013, 8:48 a.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15344/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2013, 8:48 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Darren Shepherd.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4916
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4916
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> To enable Data base High Availability for cloud stack management server database. We have used Mysql's connector parameters to switch between master and slaves along with mysql's 2-way replication and chain way of replication for more than 2 nodes
> 
> https://wikis.oracle.com/display/CommSuite/MySQL+High+Availability+and+Replication+Information+For+Calendar+Server#MySQLHighAvailabilityandReplicationInformationForCalendarServer-MySQLServerTwoWayReplicationExample
> 
> Due ot this defect http://bugs.mysql.com/bug.php?id=68141 changed 2 files to have synchronized for on block of statements which were cauing Thread BLOCKING..
> 
> 
> Diffs
> -----
> 
>   client/tomcatconf/db.properties.in b0cb22b 
>   framework/db/src/com/cloud/utils/db/ConnectionConcierge.java acb9cc6 
>   framework/db/src/com/cloud/utils/db/Merovingian2.java 8544aab 
>   framework/db/src/com/cloud/utils/db/TransactionLegacy.java a874ce1 
> 
> Diff: https://reviews.apache.org/r/15344/diff/
> 
> 
> Testing
> -------
> 
> Basic sanity testing is done using 2 nodes. If any transaction(api request) is in between and if server goes down then that api request will fail
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Re: Review Request 15344: Enabling DB HA for cloud stack data bases using mysql active-active solution

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15344/#review28861
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On Nov. 14, 2013, 5:17 a.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15344/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 5:17 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Darren Shepherd.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4916
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4916
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> To enable Data base High Availability for cloud stack management server database. We have used Mysql's connector parameters to switch between master and slaves along with mysql's 2-way replication and chain way of replication for more than 2 nodes
> 
> https://wikis.oracle.com/display/CommSuite/MySQL+High+Availability+and+Replication+Information+For+Calendar+Server#MySQLHighAvailabilityandReplicationInformationForCalendarServer-MySQLServerTwoWayReplicationExample
> 
> Due ot this defect http://bugs.mysql.com/bug.php?id=68141 changed 2 files to have synchronized for on block of statements which were cauing Thread BLOCKING..
> 
> 
> Diffs
> -----
> 
>   client/tomcatconf/db.properties.in 31e0803 
>   framework/db/pom.xml 5af00a0 
>   framework/db/src/com/cloud/utils/db/StaticStrategy.java PRE-CREATION 
>   framework/db/src/com/cloud/utils/db/TransactionLegacy.java 39893bd 
> 
> Diff: https://reviews.apache.org/r/15344/diff/
> 
> 
> Testing
> -------
> 
> Basic sanity testing is done using 2 nodes. If any transaction(api request) is in between and if server goes down then that api request will fail
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Re: Review Request 15344: Enabling DB HA for cloud stack data bases using mysql active-active solution

Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15344/
-----------------------------------------------------------

(Updated Nov. 14, 2013, 5:17 a.m.)


Review request for cloudstack, Abhinandan Prateek and Darren Shepherd.


Changes
-------

Forgot to add the licensing to the new file. Added the same and re uploading the new diff.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4916
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4916


Repository: cloudstack-git


Description
-------

To enable Data base High Availability for cloud stack management server database. We have used Mysql's connector parameters to switch between master and slaves along with mysql's 2-way replication and chain way of replication for more than 2 nodes

https://wikis.oracle.com/display/CommSuite/MySQL+High+Availability+and+Replication+Information+For+Calendar+Server#MySQLHighAvailabilityandReplicationInformationForCalendarServer-MySQLServerTwoWayReplicationExample

Due ot this defect http://bugs.mysql.com/bug.php?id=68141 changed 2 files to have synchronized for on block of statements which were cauing Thread BLOCKING..


Diffs (updated)
-----

  client/tomcatconf/db.properties.in 31e0803 
  framework/db/pom.xml 5af00a0 
  framework/db/src/com/cloud/utils/db/StaticStrategy.java PRE-CREATION 
  framework/db/src/com/cloud/utils/db/TransactionLegacy.java 39893bd 

Diff: https://reviews.apache.org/r/15344/diff/


Testing
-------

Basic sanity testing is done using 2 nodes. If any transaction(api request) is in between and if server goes down then that api request will fail


Thanks,

Damodar Reddy Talakanti


Re: Review Request 15344: Enabling DB HA for cloud stack data bases using mysql active-active solution

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15344/#review28860
-----------------------------------------------------------


Add license header to StaticStrategy.java

- Abhinandan Prateek


On Nov. 12, 2013, 12:43 p.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15344/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 12:43 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Darren Shepherd.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4916
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4916
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> To enable Data base High Availability for cloud stack management server database. We have used Mysql's connector parameters to switch between master and slaves along with mysql's 2-way replication and chain way of replication for more than 2 nodes
> 
> https://wikis.oracle.com/display/CommSuite/MySQL+High+Availability+and+Replication+Information+For+Calendar+Server#MySQLHighAvailabilityandReplicationInformationForCalendarServer-MySQLServerTwoWayReplicationExample
> 
> Due ot this defect http://bugs.mysql.com/bug.php?id=68141 changed 2 files to have synchronized for on block of statements which were cauing Thread BLOCKING..
> 
> 
> Diffs
> -----
> 
>   client/tomcatconf/db.properties.in 31e0803 
>   framework/db/pom.xml 5af00a0 
>   framework/db/src/com/cloud/utils/db/StaticStrategy.java PRE-CREATION 
>   framework/db/src/com/cloud/utils/db/TransactionLegacy.java 39893bd 
> 
> Diff: https://reviews.apache.org/r/15344/diff/
> 
> 
> Testing
> -------
> 
> Basic sanity testing is done using 2 nodes. If any transaction(api request) is in between and if server goes down then that api request will fail
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Re: Review Request 15344: Enabling DB HA for cloud stack data bases using mysql active-active solution

Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15344/
-----------------------------------------------------------

(Updated Nov. 12, 2013, 12:43 p.m.)


Review request for cloudstack, Abhinandan Prateek and Darren Shepherd.


Changes
-------

Fixing the issue with db connections after master goes down in case of having more than 2 db nodes.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4916
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4916


Repository: cloudstack-git


Description
-------

To enable Data base High Availability for cloud stack management server database. We have used Mysql's connector parameters to switch between master and slaves along with mysql's 2-way replication and chain way of replication for more than 2 nodes

https://wikis.oracle.com/display/CommSuite/MySQL+High+Availability+and+Replication+Information+For+Calendar+Server#MySQLHighAvailabilityandReplicationInformationForCalendarServer-MySQLServerTwoWayReplicationExample

Due ot this defect http://bugs.mysql.com/bug.php?id=68141 changed 2 files to have synchronized for on block of statements which were cauing Thread BLOCKING..


Diffs (updated)
-----

  client/tomcatconf/db.properties.in 31e0803 
  framework/db/pom.xml 5af00a0 
  framework/db/src/com/cloud/utils/db/StaticStrategy.java PRE-CREATION 
  framework/db/src/com/cloud/utils/db/TransactionLegacy.java 39893bd 

Diff: https://reviews.apache.org/r/15344/diff/


Testing
-------

Basic sanity testing is done using 2 nodes. If any transaction(api request) is in between and if server goes down then that api request will fail


Thanks,

Damodar Reddy Talakanti