You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2015/06/16 08:54:14 UTC
git commit: updated refs/heads/master to 9bb920a
Repository: cloudstack
Updated Branches:
refs/heads/master 3d48af41a -> 9bb920af6
Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency
Signed-off-by: Daan Hoogland <da...@gmail.com>
This closes #461
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/9bb920af
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/9bb920af
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/9bb920af
Branch: refs/heads/master
Commit: 9bb920af65c6fcf5eb8cbf5e3fc5f2025cef7332
Parents: 3d48af4
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Mon Jun 15 19:18:34 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Tue Jun 16 08:53:56 2015 +0200
----------------------------------------------------------------------
.../cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/9bb920af/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
index 4d2197a..0bf8d99 100644
--- a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
+++ b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
@@ -256,7 +256,7 @@ public class VmwareStorageManagerImpl implements VmwareStorageManager {
try {
VmwareHypervisorHost hyperHost = hostService.getHyperHost(context, cmd);
- String templateUuidName = UUID.nameUUIDFromBytes((templateName + "@" + cmd.getPoolUuid() + "-" + hyperHost.getMor().getValue()).getBytes()).toString();
+ String templateUuidName = UUID.nameUUIDFromBytes((templateName + "@" + cmd.getPoolUuid() + "-" + hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
// truncate template name to 32 chars to ensure they work well with vSphere API's.
templateUuidName = templateUuidName.replace("-", "");