[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4860: Cleanup raw type Iterator warnings..

[GitBox <gi...@apache.org>]

matthiasblaesing commented on code in PR #4860:
URL: https://github.com/apache/netbeans/pull/4860#discussion_r1037532428


##########
enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/DDChangesPanel.java:
##########
@@ -101,12 +101,12 @@ public java.awt.Dimension getPreferredSize () {
         return new java.awt.Dimension(600, 400);
     }
     
-    synchronized void setChanges (List changes) {
-        listModel.clear ();
+    synchronized void setChanges(List<DefaultListModel> changes) {

Review Comment:
   The same problem exists in the other `DDChangesPanels`. One example:
   
   This:
   
   https://github.com/apache/netbeans/blob/a24cc09173f80127ab311d59fbeb7d68de40cbc5/enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/DDChangesPanel.java#L104-L112
   
   is called from here (472):
   
   https://github.com/apache/netbeans/blob/a24cc09173f80127ab311d59fbeb7d68de40cbc5/enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/EarDataObject.java#L381-L480
   
   is called from here:
   
   https://github.com/apache/netbeans/blob/a24cc09173f80127ab311d59fbeb7d68de40cbc5/enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/EarDataObject.java#L350-L379
   
   `changes` is initialized from `updates`, which is:
   
   https://github.com/apache/netbeans/blob/a24cc09173f80127ab311d59fbeb7d68de40cbc5/enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/EarDataObject.java#L95
   
   So this change allows you to stuff a `DDChangeEvent` into a `List<DefaultListModel>`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists