You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 07:33:29 UTC
[GitHub] [flink] ifndef-SleePy opened a new pull request #10837: [hotfix]
Fix unstable case FlinkKinesisConsumerTest
ifndef-SleePy opened a new pull request #10837: [hotfix] Fix unstable case FlinkKinesisConsumerTest
URL: https://github.com/apache/flink/pull/10837
## What is the purpose of the change
* It's a quick fix for `FlinkKinesisConsumerTest#testSourceSynchronization`. This checking should happen before `throwOnCollect` is set.
## Brief change log
* Fix the bug of wrong checking introduced by FLINK-15301
## Verifying this change
* This is a fixing of test case
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10837: [FLINK-15541]
Fix unstable case FlinkKinesisConsumerTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10837: [FLINK-15541] Fix unstable case FlinkKinesisConsumerTest
URL: https://github.com/apache/flink/pull/10837#issuecomment-573544281
<!--
Meta data
Hash:4d045d632eb72a162e5d56aa52a6819042d2f1aa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4281 TriggerType:PUSH TriggerID:4d045d632eb72a162e5d56aa52a6819042d2f1aa
Hash:4d045d632eb72a162e5d56aa52a6819042d2f1aa Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144107145 TriggerType:PUSH TriggerID:4d045d632eb72a162e5d56aa52a6819042d2f1aa
-->
## CI report:
* 4d045d632eb72a162e5d56aa52a6819042d2f1aa Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144107145) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10837: [FLINK-15541]
Fix unstable case FlinkKinesisConsumerTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10837: [FLINK-15541] Fix unstable case FlinkKinesisConsumerTest
URL: https://github.com/apache/flink/pull/10837#issuecomment-573544281
<!--
Meta data
Hash:4d045d632eb72a162e5d56aa52a6819042d2f1aa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4281 TriggerType:PUSH TriggerID:4d045d632eb72a162e5d56aa52a6819042d2f1aa
Hash:4d045d632eb72a162e5d56aa52a6819042d2f1aa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144107145 TriggerType:PUSH TriggerID:4d045d632eb72a162e5d56aa52a6819042d2f1aa
-->
## CI report:
* 4d045d632eb72a162e5d56aa52a6819042d2f1aa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144107145) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10837: [FLINK-15541] Fix
unstable case FlinkKinesisConsumerTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10837: [FLINK-15541] Fix unstable case FlinkKinesisConsumerTest
URL: https://github.com/apache/flink/pull/10837#issuecomment-573544281
<!--
Meta data
Hash:4d045d632eb72a162e5d56aa52a6819042d2f1aa Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4d045d632eb72a162e5d56aa52a6819042d2f1aa
-->
## CI report:
* 4d045d632eb72a162e5d56aa52a6819042d2f1aa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10837: [FLINK-15541] Fix
unstable case FlinkKinesisConsumerTest
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10837: [FLINK-15541] Fix unstable case FlinkKinesisConsumerTest
URL: https://github.com/apache/flink/pull/10837#issuecomment-573708186
Yes, this looks good! I'll merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha closed pull request #10837: [FLINK-15541] Fix
unstable case FlinkKinesisConsumerTest
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #10837: [FLINK-15541] Fix unstable case FlinkKinesisConsumerTest
URL: https://github.com/apache/flink/pull/10837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10837: [FLINK-15541] Fix
unstable case FlinkKinesisConsumerTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10837: [FLINK-15541] Fix unstable case FlinkKinesisConsumerTest
URL: https://github.com/apache/flink/pull/10837#issuecomment-573541515
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4d045d632eb72a162e5d56aa52a6819042d2f1aa (Mon Jan 13 07:40:30 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15541).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10837: [FLINK-15541]
Fix unstable case FlinkKinesisConsumerTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10837: [FLINK-15541] Fix unstable case FlinkKinesisConsumerTest
URL: https://github.com/apache/flink/pull/10837#issuecomment-573544281
<!--
Meta data
Hash:4d045d632eb72a162e5d56aa52a6819042d2f1aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4281 TriggerType:PUSH TriggerID:4d045d632eb72a162e5d56aa52a6819042d2f1aa
Hash:4d045d632eb72a162e5d56aa52a6819042d2f1aa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144107145 TriggerType:PUSH TriggerID:4d045d632eb72a162e5d56aa52a6819042d2f1aa
-->
## CI report:
* 4d045d632eb72a162e5d56aa52a6819042d2f1aa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144107145) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services