You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/27 13:25:01 UTC
[GitHub] cloud-fan commented on issue #23171: [SPARK-26205][SQL] Optimize In
for bytes, shorts, ints
cloud-fan commented on issue #23171: [SPARK-26205][SQL] Optimize In for bytes, shorts, ints
URL: https://github.com/apache/spark/pull/23171#issuecomment-467860408
> the main idea of `InSet` was to optimize cases when the list of values is long rather than to optimize cases when all values are literals.
"all values are literals" is a pre-condition. If some values are attributes, we can't use hash set no matter how long the list of values is.
But I'm fine to add the switch optimization in `InSet`, we can rename it to `OptimizedIn` later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org