You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "olabusayoT (via GitHub)" <gi...@apache.org> on 2026/02/25 19:11:27 UTC
[PR] Replace `ParseError` with `MultiException` in `FuzzData` [daffodil]
olabusayoT opened a new pull request, #1634:
URL: https://github.com/apache/daffodil/pull/1634
- Updated logic to handle multiple exceptions using `MultiException`, replacing the older `ParseError` usage across methods in `FuzzData.scala`.
- Adjusted related method and variable names for consistency.
DAFFODIL-3075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace `ParseError` with `MultiException` in `FuzzData` [daffodil]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #1634:
URL: https://github.com/apache/daffodil/pull/1634#discussion_r2854894053
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/util/FuzzData.scala:
##########
@@ -175,8 +175,8 @@ class FuzzParseTester(
try {
TestUtils.runDataProcessorOnInputStream(p, bais, areTracing = false)
} catch {
- case p: ParseError => {
- handleParseError(p, testData, i)
+ case p: MultiException[Throwable] @unchecked => {
Review Comment:
Does this need to be marked as unchecked?
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/util/FuzzData.scala:
##########
@@ -207,7 +211,11 @@ class LayerParseTester(
var shouldFail = false
- override def handleParseError(p: ParseError, data: Array[Byte], nth: Int): Unit = {
Review Comment:
Is it worth changing the argument names from `p` to `ex` or something to better match what the argument represents?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace `ParseError` with `MultiException` in `FuzzData` [daffodil]
Posted by "olabusayoT (via GitHub)" <gi...@apache.org>.
olabusayoT merged PR #1634:
URL: https://github.com/apache/daffodil/pull/1634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace `ParseError` with `MultiException` in `FuzzData` [daffodil]
Posted by "olabusayoT (via GitHub)" <gi...@apache.org>.
olabusayoT commented on code in PR #1634:
URL: https://github.com/apache/daffodil/pull/1634#discussion_r2855394941
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/util/FuzzData.scala:
##########
@@ -175,8 +175,8 @@ class FuzzParseTester(
try {
TestUtils.runDataProcessorOnInputStream(p, bais, areTracing = false)
} catch {
- case p: ParseError => {
- handleParseError(p, testData, i)
+ case p: MultiException[Throwable] @unchecked => {
Review Comment:
Yes the compiler complains otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org