You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/12 12:08:36 UTC

[GitHub] [arrow] stiga-huang commented on a diff in pull request #14380: ARROW-17995: [C++] Fix json decimals not being rescaled based on the explicit schema

stiga-huang commented on code in PR #14380:
URL: https://github.com/apache/arrow/pull/14380#discussion_r993372376


##########
cpp/src/arrow/json/converter_test.cc:
##########
@@ -190,9 +190,12 @@ TEST(ConverterTest, Decimal128And256) {
     options.explicit_schema = schema({field("", decimal_type)});
 
     std::string json_source = R"(
-    {"" : "02.0000000000"}
-    {"" : "30.0000000000"}
-  )";
+      {"" : "02.0000000000"}
+      {"" : "30.0000000000"}
+      {"" : "30.01"}
+      {"" : "30.0000000000123"}

Review Comment:
   Yeah, I think users would like different behaviors. E.g. in Impala, we'd like Arrow to continue reading the remaining rows instead of throwing an error and stop.
   
   I think we can add an option to choose the behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org