[jira] [Issue Comment Edited] (MAHOUT-874) Extract Writables into a separate module to allow smaller dependencies

["Grant Ingersoll (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144980#comment-13144980 ] 

Grant Ingersoll edited comment on MAHOUT-874 at 11/6/11 11:33 AM:
------------------------------------------------------------------

Why is Cluster even dependent on VectorWritable?  Shouldn't it just be dependent on Vector?  Seems to me that VectorWritable should only ever be instantiated inside of a Map/Reduce job.  All the core stuff should just take Vector.

Stuff like:
{code}
@Override
  public void observe(VectorWritable x) {
    observe(x.get());
  }
{code}

just seems silly.  We already have observe(Vector).

Not that it necessarily solves the problem just yet, but it still strikes me as not needed.  Perhaps the same is also true for Model?  In fact, could Model be moved to Math?  Seems fairly generic and perhaps useful outside of clustering?.  Then, we could have ModelWritable which takes care of the Writable part of it.
                
      was (Author: gsingers):
    Why is Cluster even dependent on VectorWritable?  Shouldn't it just be dependent on Vector?  Seems to me that VectorWritable should only ever be instantiated inside of a Map/Reduce job.  All the core stuff should just take Vector.

Stuff like:
{code}
@Override
  public void observe(VectorWritable x) {
    observe(x.get());
  }
{code}

just seems silly.  We already have observe(Vector).
                  
> Extract Writables into a separate module to allow smaller dependencies
> ----------------------------------------------------------------------
>
>                 Key: MAHOUT-874
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-874
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Ted Dunning
>
> The theory is that we can have a smaller jar if we only include writable classes and their exact dependencies.
> I have a prototype, but it has some funky characteristics which I would like to discuss.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira