You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/04 19:25:38 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #14588: Fill DagBag from dag_folder setting for upgrade rules

kaxil commented on a change in pull request #14588:
URL: https://github.com/apache/airflow/pull/14588#discussion_r587755783



##########
File path: airflow/upgrade/rules/no_additional_args_in_operators.py
##########
@@ -43,7 +42,11 @@ def check(self, dags_folder=None):
         old_level = logger.level
         try:
             logger.setLevel(logging.ERROR)
-            dagbag = DagBag(dag_folder=os.devnull, include_examples=False, store_serialized_dags=False)
+            dagbag = DagBag(
+                dag_folder=conf.get("core", "dags_folder"),

Review comment:
       ```suggestion
                   dag_folder=dags_folder,
   ```
   
   Since we already get the config on L39




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org