You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/11 14:35:24 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5852: server: find suitable disk offering for volume upload
shwstppr opened a new pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852
### Description
Fixes #5696
Find suitable custom disk offering for volume upload based on the zone.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026781740
@sureshanaparti
Made UI change for your first issue
Not able reproduce second issue. Error shown when offering from a different zone is selected while upload from URL,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024967595
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1010947371
The offering name should not matter.
I would like to see the user have the opportunity to choose an offering and maybe even create one during the upload process. For now this seems a bit out of scope. Just something to think about.
Let me know when this is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1010622572
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024956985
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024973982
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024967924
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1025080502
<b>Trillian test result (tid-3054)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37416 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5852-t3054-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1027363951
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1011051234
<b>Trillian test result (tid-2862)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31305 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5852-t2862-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1023210979
@shwstppr I have considered only upload from local in my testing but @sureshanaparti pointed me to the upload from url dialog. I think we'll need to look at this as well. It displays a complete set of offerings while it should probably automatically select a constom offering for the current zone as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1023983960
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026797903
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026790123
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1010622791
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1010221934
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1017232046
> The offering name should not matter. I would like to see the user have the opportunity to choose an offering and maybe even create one during the upload process. For now this seems a bit out of scope. Just something to think about.
>
> Let me know when this is ready for review.
@DaanHoogland uploadVolume API does have a param to specify diskoffering. Creating a new offering during volume upload itself in the UI won't make a lot of sense as disk offering creation by default is not allowed to default User role.
Sorry forgot to ping you after marking the PR ready for review but I guess you already noticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1023008942
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1022974070
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024925374
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026792653
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026855068
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024967302
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 2378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024937450
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024973916
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr edited a comment on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026781740
@sureshanaparti
Made UI change for your first issue
~Not able reproduce second issue. Error shown when offering from a different zone is selected while upload from URL,~
Reverted access check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1027399639
<b>Trillian test result (tid-3105)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34843 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5852-t3105-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1027366911
<b>Trillian Build Failed (tid-3109)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026792653
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1022973046
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1027366911
<b>Trillian Build Failed (tid-3109)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024127625
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024131426
@blueorangutan package help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024131426
@blueorangutan package help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1023983122
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024925195
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1010272389
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024253859
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024957053
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024956985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1025716147
@shwstppr Upload volume from URL lists disk offerings with name, whereas Upload volume from Local lists disk offerings with display name, please make them consistent. and When selecting other zone's disk offering in Upload volume from URL, it is not throwing access permission error (which it shown earlier).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026807390
@sureshanaparti @DaanHoogland I've refactored code changes to use `checkAccess` so a valid offering can be found using both zone and owner's domain.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1010222256
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1010880181
code looks good so far, @shwstppr How far is this from done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1027654078
> @sureshanaparti
>
> Made UI change for your first issue ~Not able reproduce second issue. Error shown when offering from a different zone is selected while upload from URL,~
>
> Reverted access check
Verified the UI changes, looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026807853
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026790123
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1026796212
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1027363768
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1027822031
Tested upload from local and url with user and admin accounts with latest changes. Also, verified the access restriction on other zone's disk offering while uploading volume from url. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024973564
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024967302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1024132783
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5852: server: find suitable disk offering for volume upload
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5852:
URL: https://github.com/apache/cloudstack/pull/5852#issuecomment-1010908551
@DaanHoogland I was not able to test a multi-zone setup yet. Also, I was not sure if it will correct to use a different custom offering as default other than one with unique_name=Cloud.com-Custom. So would like other's opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org