You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/05/12 23:47:31 UTC

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #6829: Fix Internal Server Error when updating server without the id key

ericholguin opened a new pull request, #6829:
URL: https://github.com/apache/trafficcontrol/pull/6829

   <!--
   Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
   If this closes or relates to an existing issue, please reference it using one of the following:
   
   Closes: #6828 
   
   If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   -->
   
   Fixes: #6828 
   
   Fixes issue where updating a server without an `id` key in the request body results in an Internal Server Error for api v3 and v4. This also fixes the issue when updating a server without a `profile` key in the request body results in an Internal Server Error for api v3 and v2.
   
   In addition this fixes a previous bug in Traffic Ops that would not allow a user to update a server without the `id` key due to:
   
   https://github.com/apache/trafficcontrol/blob/8c13de7054acf8554412c59fdf543ff30759b3ab/traffic_ops/traffic_ops_golang/server/servers.go#L653-L672
   
   When the `id` key was omitted it resulted in that s.ID always being nil and resulting in the incorrect error message and incorrect 400 Bad Request.
   
   
   <!-- **^ Add meaningful description above** --><hr/>
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this PR.
   Feel free to add the name of a tool or script that is affected but not on the list.
   -->
   
   - Traffic Ops
   
   
   ## What is the best way to verify this PR?
   <!-- Please include here ALL the steps necessary to test your PR.
   If your PR has tests (and most should), provide the steps needed to run the tests.
   If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
   
   Make a `PUT` request to `/api/4.0/servers` without the `id` in the request body this should return a `200 OK`
   Make a `PUT` request to `/api/3.1/servers` without the `id` in the request body this should return a `200 OK`
   
   Make a `PUT` request to `/api/3.1/servers` without the `profile` in the request body this should return a `200 OK`
   Make a `PUT` request to `/api/2.0/servers` without the `profile` in the request body this should return a `200 OK`
   
   ## PR submission checklist
   
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rimashah25 commented on pull request #6829: Fix Internal Server Error when updating server without the id key

Posted by GitBox <gi...@apache.org>.
rimashah25 commented on PR #6829:
URL: https://github.com/apache/trafficcontrol/pull/6829#issuecomment-1128969120

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp merged pull request #6829: Fix Internal Server Error when updating server without the id key

Posted by GitBox <gi...@apache.org>.
rawlinp merged PR #6829:
URL: https://github.com/apache/trafficcontrol/pull/6829


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org