You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Aihua Xu <ax...@cloudera.com> on 2015/11/02 17:56:50 UTC
Review Request 39863: HIVE-12304 "drop database cascade" needs to
unregister functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39863/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-12304 "drop database cascade" needs to unregister functions
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java dcac9ca900e58ae6996657247e7d7931d5f67ac1
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java de8e98ca34bff9230b74d2e5309557529b1c07ba
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 1121819dea6195d4dfbd223b2ac5b8cc87c386f9
ql/src/test/queries/clientnegative/drop_database_cascade.q PRE-CREATION
ql/src/test/results/clientnegative/drop_database_cascade.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/39863/diff/
Testing
-------
Thanks,
Aihua Xu
Re: Review Request 39863: HIVE-12304 "drop database cascade" needs to
unregister functions
Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39863/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 8:23 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-12304 "drop database cascade" needs to unregister functions
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java caf98b5
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java de8e98c
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 1121819
ql/src/test/queries/clientnegative/drop_database_cascade.q PRE-CREATION
ql/src/test/results/clientnegative/drop_database_cascade.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/39863/diff/
Testing
-------
Thanks,
Aihua Xu
Re: Review Request 39863: HIVE-12304 "drop database cascade" needs to
unregister functions
Posted by Aihua Xu <ax...@cloudera.com>.
> On Nov. 2, 2015, 6:32 p.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 1554
> > <https://reviews.apache.org/r/39863/diff/1/?file=1114074#file1114074line1554>
> >
> > I don't think this is needed, since temp functions do not have an associated database
You are right. It's not needed.
> On Nov. 2, 2015, 6:32 p.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java, line 428
> > <https://reviews.apache.org/r/39863/diff/1/?file=1114075#file1114075line428>
> >
> > Does '.' need to be escaped since this is doing regex pattern matching?
Yeah. Changed the pattern to \..* .
- Aihua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39863/#review104748
-----------------------------------------------------------
On Nov. 2, 2015, 4:56 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39863/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 4:56 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-12304 "drop database cascade" needs to unregister functions
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java dcac9ca900e58ae6996657247e7d7931d5f67ac1
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java de8e98ca34bff9230b74d2e5309557529b1c07ba
> ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 1121819dea6195d4dfbd223b2ac5b8cc87c386f9
> ql/src/test/queries/clientnegative/drop_database_cascade.q PRE-CREATION
> ql/src/test/results/clientnegative/drop_database_cascade.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39863/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 39863: HIVE-12304 "drop database cascade" needs to
unregister functions
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39863/#review104748
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java (line 1554)
<https://reviews.apache.org/r/39863/#comment162994>
I don't think this is needed, since temp functions do not have an associated database
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java (line 428)
<https://reviews.apache.org/r/39863/#comment162995>
Does '.' need to be escaped since this is doing regex pattern matching?
- Jason Dere
On Nov. 2, 2015, 4:56 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39863/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 4:56 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-12304 "drop database cascade" needs to unregister functions
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java dcac9ca900e58ae6996657247e7d7931d5f67ac1
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java de8e98ca34bff9230b74d2e5309557529b1c07ba
> ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 1121819dea6195d4dfbd223b2ac5b8cc87c386f9
> ql/src/test/queries/clientnegative/drop_database_cascade.q PRE-CREATION
> ql/src/test/results/clientnegative/drop_database_cascade.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39863/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aihua Xu
>
>