You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/10 19:24:32 UTC

svn commit: r1695137 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/

Author: sebb
Date: Mon Aug 10 17:24:31 2015
New Revision: 1695137

URL: http://svn.apache.org/r1695137
Log:
TODOs

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantClass.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantDouble.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFloat.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInteger.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantLong.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodHandle.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodType.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantNameAndType.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantString.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantValue.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Deprecated.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/FieldOrMethod.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClass.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java Mon Aug 10 17:24:31 2015
@@ -36,12 +36,12 @@ import org.apache.commons.bcel6.Constant
 public final class CodeException implements Cloneable, Constants, Node, Serializable {
 
     private static final long serialVersionUID = 2972500041254967221L;
-    private int start_pc; // Range in the code the exception handler is
-    private int end_pc; // active. start_pc is inclusive, end_pc exclusive
-    private int handler_pc; /* Starting address of exception handler, i.e.,
+    private int start_pc; // Range in the code the exception handler is TODO could be final (setter unused)
+    private int end_pc; // active. start_pc is inclusive, end_pc exclusive TODO could be final (setter unused)
+    private int handler_pc; /* Starting address of exception handler, i.e., TODO could be final (setter unused)
      * an offset from start of code.
      */
-    private int catch_type; /* If this is zero the handler catches any
+    private int catch_type; /* If this is zero the handler catches any TODO could be final (setter unused)
      * exception, otherwise it points to the
      * exception class which is to be caught.
      */
@@ -146,7 +146,7 @@ public final class CodeException impleme
     /**
      * @param catch_type the type of exception that is caught
      */
-    public final void setCatchType( int catch_type ) {
+    public final void setCatchType( int catch_type ) { // TODO unused
         this.catch_type = catch_type;
     }
 
@@ -154,7 +154,7 @@ public final class CodeException impleme
     /**
      * @param end_pc end of handled block
      */
-    public final void setEndPC( int end_pc ) {
+    public final void setEndPC( int end_pc ) { // TODO unused
         this.end_pc = end_pc;
     }
 
@@ -162,7 +162,7 @@ public final class CodeException impleme
     /**
      * @param handler_pc where the actual code is
      */
-    public final void setHandlerPC( int handler_pc ) {
+    public final void setHandlerPC( int handler_pc ) { // TODO unused
         this.handler_pc = handler_pc;
     }
 
@@ -170,7 +170,7 @@ public final class CodeException impleme
     /**
      * @param start_pc start of handled block
      */
-    public final void setStartPC( int start_pc ) {
+    public final void setStartPC( int start_pc ) { // TODO unused
         this.start_pc = start_pc;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java Mon Aug 10 17:24:31 2015
@@ -41,9 +41,9 @@ public abstract class ConstantCP extends
      */
     // Note that this field is used to store the
     // bootstrap_method_attr_index of a ConstantInvokeDynamic.
-    protected int class_index; // TODO make private (has getter & setter)
+    protected int class_index; // TODO make private (has getter & setter) could be final (setter unused)
     // This field has the same meaning for all subclasses.
-    protected int name_and_type_index; // TODO make private (has getter & setter)
+    protected int name_and_type_index; // TODO make private (has getter & setter) could be final (setter unused)
 
 
     /**
@@ -113,7 +113,7 @@ public abstract class ConstantCP extends
     /**
      * @param class_index points to Constant_class 
      */
-    public final void setClassIndex( int class_index ) {
+    public final void setClassIndex( int class_index ) { // TODO unused
         this.class_index = class_index;
     }
 
@@ -124,7 +124,7 @@ public abstract class ConstantCP extends
      * Note that this method is a functional duplicate of setClassIndex
      * for use by ConstantInvokeDynamic.
      */
-    public final void setBootstrapMethodAttrIndex(int bootstrap_method_attr_index) {
+    public final void setBootstrapMethodAttrIndex(int bootstrap_method_attr_index) { // TODO unused
         this.class_index = bootstrap_method_attr_index;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantClass.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantClass.java Mon Aug 10 17:24:31 2015
@@ -35,7 +35,7 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantClass extends Constant implements ConstantObject {
 
     private static final long serialVersionUID = -1083450233715258720L;
-    private int name_index; // Identical to ConstantString except for the name
+    private int name_index; // Identical to ConstantString except for the name TODO could be final (setter unused)
 
 
     /**

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantDouble.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantDouble.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantDouble.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantDouble.java Mon Aug 10 17:24:31 2015
@@ -35,7 +35,7 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantDouble extends Constant implements ConstantObject {
 
     private static final long serialVersionUID = -7394764537394782136L;
-    private double bytes;
+    private double bytes; // TODO could be final (setter not used)
 
 
     /** 
@@ -103,7 +103,7 @@ public final class ConstantDouble extend
     /**
      * @param bytes the raw bytes that represent the double value
      */
-    public final void setBytes( double bytes ) {
+    public final void setBytes( double bytes ) { // TODO unused
         this.bytes = bytes;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFloat.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFloat.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFloat.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFloat.java Mon Aug 10 17:24:31 2015
@@ -35,7 +35,7 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantFloat extends Constant implements ConstantObject {
 
     private static final long serialVersionUID = -2316732495687628398L;
-    private float bytes;
+    private float bytes; // TODO could be final (setter unused)
 
 
     /** 
@@ -104,7 +104,7 @@ public final class ConstantFloat extends
     /**
      * @param bytes the raw bytes that represent this float
      */
-    public final void setBytes( float bytes ) {
+    public final void setBytes( float bytes ) { // TODO unused
         this.bytes = bytes;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInteger.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInteger.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInteger.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInteger.java Mon Aug 10 17:24:31 2015
@@ -35,7 +35,7 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantInteger extends Constant implements ConstantObject {
 
     private static final long serialVersionUID = -7040676276945754375L;
-    private int bytes;
+    private int bytes; // TODO could be final (setter unused)
 
 
     /** 
@@ -103,7 +103,7 @@ public final class ConstantInteger exten
     /**
      * @param bytes the raw bytes that represent this integer
      */
-    public final void setBytes( int bytes ) {
+    public final void setBytes( int bytes ) { // TODO unused
         this.bytes = bytes;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantLong.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantLong.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantLong.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantLong.java Mon Aug 10 17:24:31 2015
@@ -35,7 +35,7 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantLong extends Constant implements ConstantObject {
 
     private static final long serialVersionUID = 8495971186433816161L;
-    private long bytes;
+    private long bytes; // TODO could be final (setter unused)
 
 
     /** 
@@ -103,7 +103,7 @@ public final class ConstantLong extends
     /**
      * @param bytes the raw bytes that represent this long
      */
-    public final void setBytes( long bytes ) {
+    public final void setBytes( long bytes ) { // TODO unused
         this.bytes = bytes;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodHandle.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodHandle.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodHandle.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodHandle.java Mon Aug 10 17:24:31 2015
@@ -34,8 +34,8 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantMethodHandle extends Constant {
 
     private static final long serialVersionUID = -7875124116920198044L;
-    private int reference_kind;
-    private int reference_index;
+    private int reference_kind; // TODO could be final (setter unused)
+    private int reference_index; // TODO could be final (setter unused)
 
 
     /**
@@ -96,7 +96,7 @@ public final class ConstantMethodHandle
     }
 
 
-    public void setReferenceKind(int reference_kind) {
+    public void setReferenceKind(int reference_kind) { // TODO unused
         this.reference_kind = reference_kind;
     }
 
@@ -106,7 +106,7 @@ public final class ConstantMethodHandle
     }
 
 
-    public void setReferenceIndex(int reference_index) {
+    public void setReferenceIndex(int reference_index) { // TODO unused
         this.reference_index = reference_index;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodType.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodType.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodType.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodType.java Mon Aug 10 17:24:31 2015
@@ -34,7 +34,7 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantMethodType extends Constant {
 
     private static final long serialVersionUID = 6750768220616618881L;
-    private int descriptor_index;
+    private int descriptor_index; // TODO could be final (setter unused)
 
 
     /**
@@ -93,7 +93,7 @@ public final class ConstantMethodType ex
     }
 
 
-    public void setDescriptorIndex(int descriptor_index) {
+    public void setDescriptorIndex(int descriptor_index) { // TODO unused
         this.descriptor_index = descriptor_index;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantNameAndType.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantNameAndType.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantNameAndType.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantNameAndType.java Mon Aug 10 17:24:31 2015
@@ -36,8 +36,8 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantNameAndType extends Constant {
 
     private static final long serialVersionUID = -7913354727264034451L;
-    private int name_index; // Name of field/method
-    private int signature_index; // and its signature.
+    private int name_index; // Name of field/method // TODO could be final (setter unused)
+    private int signature_index; // and its signature. // TODO could be final (setter unused)
 
 
     /**
@@ -130,7 +130,7 @@ public final class ConstantNameAndType e
     /**
      * @param name_index the name index of this constant
      */
-    public final void setNameIndex( int name_index ) {
+    public final void setNameIndex( int name_index ) { // TODO unused
         this.name_index = name_index;
     }
 
@@ -138,7 +138,7 @@ public final class ConstantNameAndType e
     /**
      * @param signature_index the signature index in the constant pool of this type
      */
-    public final void setSignatureIndex( int signature_index ) {
+    public final void setSignatureIndex( int signature_index ) { // TODO unused
         this.signature_index = signature_index;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantString.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantString.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantString.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantString.java Mon Aug 10 17:24:31 2015
@@ -35,7 +35,7 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantString extends Constant implements ConstantObject {
 
     private static final long serialVersionUID = 6603144389219397225L;
-    private int string_index; // Identical to ConstantClass except for this name
+    private int string_index; // Identical to ConstantClass except for this name // TODO could be final (setter unused)
 
 
     /**
@@ -103,7 +103,7 @@ public final class ConstantString extend
     /**
      * @param string_index the index into the constant of the string value
      */
-    public final void setStringIndex( int string_index ) {
+    public final void setStringIndex( int string_index ) { // TODO unused
         this.string_index = string_index;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantValue.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantValue.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantValue.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantValue.java Mon Aug 10 17:24:31 2015
@@ -35,7 +35,7 @@ import org.apache.commons.bcel6.Constant
 public final class ConstantValue extends Attribute {
 
     private static final long serialVersionUID = -5668999920978520157L;
-    private int constantvalue_index;
+    private int constantvalue_index; // TODO could be final (setter unused)
 
 
     /**
@@ -111,7 +111,7 @@ public final class ConstantValue extends
     /**
      * @param constantvalue_index the index info the constant pool of this constant value
      */
-    public final void setConstantValueIndex( int constantvalue_index ) {
+    public final void setConstantValueIndex( int constantvalue_index ) { // TODO unused
         this.constantvalue_index = constantvalue_index;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Deprecated.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Deprecated.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Deprecated.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Deprecated.java Mon Aug 10 17:24:31 2015
@@ -35,7 +35,7 @@ import org.apache.commons.bcel6.Constant
 public final class Deprecated extends Attribute {
 
     private static final long serialVersionUID = -2242528405240201000L;
-    private byte[] bytes;
+    private byte[] bytes; // TODO could be final (setter unused)
 
 
     /**
@@ -118,7 +118,7 @@ public final class Deprecated extends At
     /**
      * @param bytes the raw bytes that represents this byte array
      */
-    public final void setBytes( byte[] bytes ) {
+    public final void setBytes( byte[] bytes ) { // TODO unused
         this.bytes = bytes;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java Mon Aug 10 17:24:31 2015
@@ -34,7 +34,7 @@ public class EnclosingMethod extends Att
 
     // Pointer to the CONSTANT_Class_info structure representing the 
     // innermost class that encloses the declaration of the current class.
-    private int classIndex;
+    private int classIndex; // TODO could be final (setter unused)
 
     // If the current class is not immediately enclosed by a method or 
     // constructor, then the value of the method_index item must be zero.  
@@ -44,7 +44,7 @@ public class EnclosingMethod extends Att
     // to in the class_index.  *It is the compiler responsibility* to 
     // ensure that the method identified by this index is the closest 
     // lexically enclosing method that includes the local/anonymous class.
-    private int methodIndex;
+    private int methodIndex; // TODO could be final (setter unused)
 
     // Ctors - and code to read an attribute in.
     EnclosingMethod(int nameIndex, int len, DataInput input, ConstantPool cpool) throws IOException {
@@ -73,8 +73,8 @@ public class EnclosingMethod extends Att
     public final int getEnclosingClassIndex() { return classIndex; }  
     public final int getEnclosingMethodIndex(){ return methodIndex;}
 
-    public final void setEnclosingClassIndex(int idx) {classIndex = idx;}
-    public final void setEnclosingMethodIndex(int idx){methodIndex= idx;}
+    public final void setEnclosingClassIndex(int idx) {classIndex = idx;} // TODO unused
+    public final void setEnclosingMethodIndex(int idx){methodIndex= idx;} // TODO unused
 
     public final ConstantClass getEnclosingClass() {
         ConstantClass c = 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/FieldOrMethod.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/FieldOrMethod.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/FieldOrMethod.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/FieldOrMethod.java Mon Aug 10 17:24:31 2015
@@ -33,6 +33,7 @@ import org.apache.commons.bcel6.Constant
 public abstract class FieldOrMethod extends AccessFlags implements Cloneable, Node {
 
     private static final long serialVersionUID = -1833306330869469714L;
+    // TODO should be made private
     protected int name_index; // Points to field name in constant pool 
     protected int signature_index; // Points to encoded signature
     protected Attribute[] attributes; // Collection of attributes
@@ -162,7 +163,7 @@ public abstract class FieldOrMethod exte
     /**
      * @param name_index Index in constant pool of object's name.
      */
-    public final void setNameIndex( int name_index ) {
+    public final void setNameIndex( int name_index ) { // TODO unused
         this.name_index = name_index;
     }
 
@@ -178,7 +179,7 @@ public abstract class FieldOrMethod exte
     /**
      * @param signature_index Index in constant pool of field signature.
      */
-    public final void setSignatureIndex( int signature_index ) {
+    public final void setSignatureIndex( int signature_index ) { // TODO unused
         this.signature_index = signature_index;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClass.java?rev=1695137&r1=1695136&r2=1695137&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClass.java Mon Aug 10 17:24:31 2015
@@ -36,10 +36,10 @@ import org.apache.commons.bcel6.Constant
 public final class InnerClass implements Cloneable, Node, Serializable {
 
     private static final long serialVersionUID = -7200195918166127614L;
-    private int inner_class_index;
-    private int outer_class_index;
-    private int inner_name_index;
-    private int inner_access_flags;
+    private int inner_class_index; // TODO could be final (setter unused)
+    private int outer_class_index; // TODO could be final (setter unused)
+    private int inner_name_index; // TODO could be final (setter unused)
+    private int inner_access_flags; // TODO could be final (setter unused)
 
 
     /**
@@ -138,7 +138,7 @@ public final class InnerClass implements
     /**
      * @param inner_access_flags access flags for this inner class
      */
-    public final void setInnerAccessFlags( int inner_access_flags ) {
+    public final void setInnerAccessFlags( int inner_access_flags ) { // TODO unused
         this.inner_access_flags = inner_access_flags;
     }
 
@@ -146,7 +146,7 @@ public final class InnerClass implements
     /**
      * @param inner_class_index index into the constant pool for this class
      */
-    public final void setInnerClassIndex( int inner_class_index ) {
+    public final void setInnerClassIndex( int inner_class_index ) { // TODO unused
         this.inner_class_index = inner_class_index;
     }
 
@@ -154,7 +154,7 @@ public final class InnerClass implements
     /**
      * @param inner_name_index index into the constant pool for this class's name
      */
-    public final void setInnerNameIndex( int inner_name_index ) {
+    public final void setInnerNameIndex( int inner_name_index ) { // TODO unused
         this.inner_name_index = inner_name_index;
     }
 
@@ -162,7 +162,7 @@ public final class InnerClass implements
     /**
      * @param outer_class_index index into the constant pool for the owning class
      */
-    public final void setOuterClassIndex( int outer_class_index ) {
+    public final void setOuterClassIndex( int outer_class_index ) { // TODO unused
         this.outer_class_index = outer_class_index;
     }