You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2024/12/03 20:32:25 UTC

[kudu-CR] [thirdparty] KUDU-3626: Upgrade thrift to version 0.21

Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22159


Change subject: [thirdparty] KUDU-3626: Upgrade thrift to version 0.21
......................................................................

[thirdparty] KUDU-3626: Upgrade thrift to version 0.21

To address CVEs like CVE-2018-1320, CVE-2019-0210 and CVE-2019-0205
in current thrift version 0.11 we are upgrading thrift to version
0.21. While Hive used version 0.16, since there were no significant
changes between 0.16 and 0.21 we can upgrade to 0.21 to be more
future proof.

Thanks to Alexey Serbin for valuable inputs for this patch.

Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
---
M cmake_modules/FindThrift.cmake
M src/kudu/thrift/sasl_client_transport.cc
M src/kudu/thrift/sasl_client_transport.h
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
5 files changed, 13 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/22159/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 4:

(2 comments)

Forgot to post my comments earlier

http://gerrit.cloudera.org:8080/#/c/22159/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22159/2//COMMIT_MSG@13
PS2, Line 13: potentially 
> Could you also mention that another reason is the presence of issues like
Done


http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh@1012
PS2, Line 1012: -DWITH_ZLIB=ON
> Do we really use ZLIB support in thrift?  I compiled it with -DWITH_ZLIB=OF
I didn't find any usages of zlib in our codebase hence disabled it.



-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 06:59:48 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22159

to look at the new patch set (#5).

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................

[thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

To address CVEs like CVE-2018-1320, CVE-2019-0210 and CVE-2019-0205
in the current Apache Thrift version 0.11.0 we are upgrading to version
0.21.0. For upgrading the version we looked at version 0.16.0 as Hive
uses it. But due to the reported issues[1][2] and also no significant
changes between 0.16.0 and 0.21.0 which can potentially break Kudu we
can think we can upgrade to 0.21.0 directly hence being more future
proof.

Thanks to Alexey Serbin for valuable inputs for this patch.

[1]https://issues.apache.org/jira/browse/THRIFT-5599
[2]https://issues.apache.org/jira/browse/THRIFT-5696

Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
---
M cmake_modules/FindThrift.cmake
M src/kudu/thrift/sasl_client_transport.cc
M src/kudu/thrift/sasl_client_transport.h
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
5 files changed, 13 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/22159/5
-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh@1012
PS2, Line 1012: -DWITH_ZLIB=OF
> Thanks for the confirmation
Yes, updated it now. For some reason I thought it was OFF.



-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 07:10:21 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22159

to look at the new patch set (#3).

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21
......................................................................

[thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21

To address CVEs like CVE-2018-1320, CVE-2019-0210 and CVE-2019-0205
in the current Apache Thrift version 0.11 we are upgrading to version
0.21. While Hive used version 0.16, since there were no significant
changes between 0.16 and 0.21 we can upgrade to 0.21 to be more
future proof.

Thanks to Alexey Serbin for valuable inputs for this patch.

Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
---
M cmake_modules/FindThrift.cmake
M src/kudu/thrift/sasl_client_transport.cc
M src/kudu/thrift/sasl_client_transport.h
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
5 files changed, 13 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/22159/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22159

to look at the new patch set (#6).

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................

[thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

To address CVEs like CVE-2018-1320, CVE-2019-0210 and CVE-2019-0205
in the current Apache Thrift version 0.11.0 we are upgrading to version
0.21.0. We initally considered using version 0.16.0 as Hive
uses it. But due to the reported issues[1][2] and no significant
changes between 0.16.0 and 0.21.0 which can potentially break Kudu we
think we can upgrade to 0.21.0 directly hence being more future
proof.

Thanks to Alexey Serbin for valuable inputs for this patch.

[1]https://issues.apache.org/jira/browse/THRIFT-5599
[2]https://issues.apache.org/jira/browse/THRIFT-5696

Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
---
M cmake_modules/FindThrift.cmake
M src/kudu/thrift/sasl_client_transport.cc
M src/kudu/thrift/sasl_client_transport.h
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
5 files changed, 13 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/22159/6
-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/739/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2024 21:01:18 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................

[thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

To address CVEs like CVE-2018-1320, CVE-2019-0210 and CVE-2019-0205
in the current Apache Thrift version 0.11.0 we are upgrading to version
0.21.0. We initally considered using version 0.16.0 as Hive
uses it. But due to the reported issues[1][2] and no significant
changes between 0.16.0 and 0.21.0 which can potentially break Kudu we
think we can upgrade to 0.21.0 directly hence being more future
proof.

Thanks to Alexey Serbin for valuable inputs for this patch.

[1]https://issues.apache.org/jira/browse/THRIFT-5599
[2]https://issues.apache.org/jira/browse/THRIFT-5696

Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Reviewed-on: http://gerrit.cloudera.org:8080/22159
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M cmake_modules/FindThrift.cmake
M src/kudu/thrift/sasl_client_transport.cc
M src/kudu/thrift/sasl_client_transport.h
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
5 files changed, 13 insertions(+), 9 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 6: Verified+1

unrelated flakies in ASAN build.


-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 16:22:21 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/744/


-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 07:06:56 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22159

to look at the new patch set (#4).

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................

[thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

To address CVEs like CVE-2018-1320, CVE-2019-0210 and CVE-2019-0205
in the current Apache Thrift version 0.11 we are upgrading to version
0.21. While Hive used version 0.16.0, due to reported issues[1][2]
and also no significant changes between 0.16 and 0.21 which can
potentially break Kuduwe can upgrade to 0.21 to be more future proof.

Thanks to Alexey Serbin for valuable inputs for this patch.

[1]https://issues.apache.org/jira/browse/THRIFT-5599
[2]https://issues.apache.org/jira/browse/THRIFT-5696
Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
---
M cmake_modules/FindThrift.cmake
M src/kudu/thrift/sasl_client_transport.cc
M src/kudu/thrift/sasl_client_transport.h
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
5 files changed, 13 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/22159/4
-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh@1012
PS2, Line 1012: -DWITH_ZLIB=ON
> I didn't find any usages of zlib in our codebase hence disabled it.
Thanks for the confirmation

I guess -DWITH_ZLIB=ON means it's enabled.

Or you are going to update this with a new patchset soon?



-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 07:03:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/22159/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22159/4//COMMIT_MSG@11
PS4, Line 11: While Hive used version 0.16, since there were no significant
            : changes between 0.16 and 0.21 we can upgrade to 0.21 to be more
            : future proof.
This is quite a word salad, consider rewriting this and or/breaking into multiple sentences.


http://gerrit.cloudera.org:8080/#/c/22159/4//COMMIT_MSG@19
PS4, Line 19: 
nit: add an empty line before Change-Id for better readability


http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh@1012
PS2, Line 1012: -DWITH_ZLIB=ON
> Do we really use ZLIB support in thrift?  I compiled it with -DWITH_ZLIB=OF
Did you miss addressing this in PS4?



-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 03:45:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/743/


-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 06:59:25 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] KUDU-3626: Upgrade thrift to version 0.21

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22159

to look at the new patch set (#2).

Change subject: [thirdparty] KUDU-3626: Upgrade thrift to version 0.21
......................................................................

[thirdparty] KUDU-3626: Upgrade thrift to version 0.21

To address CVEs like CVE-2018-1320, CVE-2019-0210 and CVE-2019-0205
in the current Apache Thrift version 0.11 we are upgrading to version
0.21. While Hive used version 0.16, since there were no significant
changes between 0.16 and 0.21 we can upgrade to 0.21 to be more
future proof.

Thanks to Alexey Serbin for valuable inputs for this patch.

Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
---
M cmake_modules/FindThrift.cmake
M src/kudu/thrift/sasl_client_transport.cc
M src/kudu/thrift/sasl_client_transport.h
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
5 files changed, 13 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/22159/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 4: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/743/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 09:36:34 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] KUDU-3626: Upgrade thrift to version 0.21

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade thrift to version 0.21
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/739/


-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2024 20:32:34 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22159/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22159/2//COMMIT_MSG@13
PS2, Line 13: future proof
Could you also mention that another reason is the presence of issues like

https://issues.apache.org/jira/browse/THRIFT-5599 and https://issues.apache.org/jira/browse/THRIFT-5696

in 0.16.0 at least?

THRIFT-5599 would lead to a build error if upgrading to 0.16.0, so 0.16.0 is a no-go unless we'd like to have an extra patch on top of stock Thrift 0.16.0 release.


http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh@1012
PS2, Line 1012: -DWITH_ZLIB=ON
Do we really use ZLIB support in thrift?  I compiled it with -DWITH_ZLIB=OFF and everything seems working OK so far.

With ZLIB support, we do compile one extra library libthriftz in 3rd-party, but I don't think we use it anywhere in the code anyway.



-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2024 21:17:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22159/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22159/3//COMMIT_MSG@7
PS3, Line 7: 0.21
nit for here and below: add the patch version 0, so this would be 0.21.0

At least that's how they version their releases according to https://github.com/apache/thrift/releases



-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2024 21:19:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 5: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/744/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 09:44:29 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )

Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5
Gerrit-Change-Number: 22159
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 16:22:25 +0000
Gerrit-HasComments: No