You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/07 09:12:07 UTC

[GitHub] [skywalking-infra-e2e] Humbertzhang commented on a change in pull request #13: Implement the run and wait part of setup

Humbertzhang commented on a change in pull request #13:
URL: https://github.com/apache/skywalking-infra-e2e/pull/13#discussion_r588998733



##########
File path: examples/simple/e2e.yaml
##########
@@ -21,18 +21,38 @@ setup:
   manifests:
     - path: busybox1.yaml
       wait: 
-        - namespace: default
+        - type: kube # wait type may not only kube. it can be `log` or `http` or else.

Review comment:
       Yes, but then in other scenarios, such as docker-compose and run, one might use other health check mechanism. I think add `type` field  in `Wait` struct can let us reuse it in other scenarios? What do you think of it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org