[jira] [Commented] (TAJO-840) Improve query result print with counting empty table.

["Tajo QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019455#comment-14019455 ] 

Tajo QA commented on TAJO-840:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12648571/TAJO-840_5.patch
  against master revision 692ae66.

    {color:green}+1 @author.{color}  The patch does not contain any @author tags.

    {color:green}+1 tests included.{color}  The patch appears to include 25 new or modified test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 188 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in tajo-core.

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/444//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/444//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/444//console

This message is automatically generated.

>  Improve query result print with counting empty table.
> ------------------------------------------------------
>
>                 Key: TAJO-840
>                 URL: https://issues.apache.org/jira/browse/TAJO-840
>             Project: Tajo
>          Issue Type: Improvement
>          Components: physical operator, worker
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.9.0, 0.8.1
>
>         Attachments: TAJO-840.patch, TAJO-840_2.patch, TAJO-840_3.patch, TAJO-840_4.patch, TAJO-840_5.patch
>
>
> If there is no data, tsql will print as follows:
> {code:xml}
> default> select * from table1;
> id,  name,  score,  type
> -------------------------------
> 1,  name1-1,  1.1,  a
> 2,  name1-2,  2.3,  b
> 3,  name1-3,  3.4,  c
> 4,  name1-4,  4.5,  d
> 5,  name1-5,  5.6,  e
> default> select count(*) from table1 where id = 10;
> Progress: 100%, response time: 0.231 sec
> ?count
> -------------------------------
> (0 rows, 0.231 sec, 0 B selected)
> {code}
> But it need to print result detailedly as follows:
> {code:xml}
> ?count
> -------------------------------
> 0
> -------------------------------
> (1 rows, 0.231 sec, 0 B selected)
> {code}
> Because if users implement some applications with TajoClient or TajoJDBC, they can't understand easy that a query finished successfully or a query finished unsuccessfully.



--
This message was sent by Atlassian JIRA
(v6.2#6252)