You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Akos Kovacs (Code Review)" <ge...@cloudera.org> on 2020/12/15 13:01:47 UTC
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Akos Kovacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16880
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
IMPALA-9687 Improve estimates for number of hosts in Kudu plans
In some cases Kudu plans could contain more hosts than the actual number of executors.
This commit fixes it by capping the number of hosts at the number of executors.
Testing:
- Ran core tests
Updated Kudu planner tests where the memory estimates changed.
Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
---
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
3 files changed, 17 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/16880/1
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 1
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 17:04:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6779/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 1
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Dec 2020 13:08:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6833/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 4
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 23:07:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 3
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 23:07:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 4
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jan 2021 04:41:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16880/1/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
http://gerrit.cloudera.org:8080/#/c/16880/1/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@a284
PS1, Line 284:
I think we still want to cap numNodes_ at hostIndexSet_.size() when the kudu tservers are colocated with Impala executors, because the scan ranges will always be scheduled locally.
E.g. if you have a situation with two hosts A and B, with all tablets of the table on A, and Impala executors on A and B, then all the scans will be scheduled on A. But your new logic calculates numNodes_ = 2.
I think instead of scanRangeSpecs_.getConcrete_rangesSize(), you want to add together the # of unique hosts with local scan ranges and the number of remote scan ranges to get the maximum number of hosts.
HdfsScanNode does a locality check like this using ExecutorMembershipSnapshot.contains().
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 1
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Dec 2020 21:23:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16880/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
http://gerrit.cloudera.org:8080/#/c/16880/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@341
PS2, Line 341: totalInstances = Math.min(numLocalInstances + numRemoteRanges, totalNodes * maxInstancesPerNode);
line too long (105 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 11:31:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 1
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Dec 2020 18:30:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
IMPALA-9687 Improve estimates for number of hosts in Kudu plans
In some cases Kudu plans could contain more hosts than the actual number of executors.
This commit fixes it by capping the number of hosts at the number of executors,
and determining which executors have local scan ranges.
Testing:
- Ran core tests
Updated Kudu planner tests where the memory estimates changed.
Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Reviewed-on: http://gerrit.cloudera.org:8080/16880
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
3 files changed, 86 insertions(+), 18 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 5
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6822/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 11:33:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 2:
(2 comments)
This is a good improvement, thank you! I had a couple more requested tweaks then I think this will be in a good state to be merged.
http://gerrit.cloudera.org:8080/#/c/16880/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
http://gerrit.cloudera.org:8080/#/c/16880/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@349
PS2, Line 349: cardinality_ == 0
I see this check came from HdfsScanNode, but I don't think it makes sense for Kudu. I think it'd be better to remove this and simplify this to something like.
numNodes_ = Math.max(totalNodes, 1);
http://gerrit.cloudera.org:8080/#/c/16880/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@359
PS2, Line 359: numInstances_ = Math.min(scanRangeSpecs_.getConcrete_rangesSize(),
I think we should set this to totalInstances computed in computeNumNodes - it should be a more accurate estimate.
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 17:22:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7972/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 3
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 23:00:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Akos Kovacs (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16880
to look at the new patch set (#3).
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
IMPALA-9687 Improve estimates for number of hosts in Kudu plans
In some cases Kudu plans could contain more hosts than the actual number of executors.
This commit fixes it by capping the number of hosts at the number of executors,
and determining which executors have local scan ranges.
Testing:
- Ran core tests
Updated Kudu planner tests where the memory estimates changed.
Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
---
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
3 files changed, 86 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/16880/3
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 3
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Akos Kovacs (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16880
to look at the new patch set (#2).
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
IMPALA-9687 Improve estimates for number of hosts in Kudu plans
In some cases Kudu plans could contain more hosts than the actual number of executors.
This commit fixes it by capping the number of hosts at the number of executors,
and determining which executors have local scan ranges.
Testing:
- Ran core tests
Updated Kudu planner tests where the memory estimates changed.
Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
---
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
3 files changed, 84 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/16880/2
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7859/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 1
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Dec 2020 13:23:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Akos Kovacs (Code Review)" <ge...@cloudera.org>.
Akos Kovacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 3:
> (2 comments)
>
> This is a good improvement, thank you! I had a couple more
> requested tweaks then I think this will be in a good state to be
> merged.
Thanks for the review and the detailed comments, Tim!
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 3
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 22:40:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6834/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 4
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 23:48:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7953/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 11:52:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9687 Improve estimates for number of hosts in Kudu plans
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16880 )
Change subject: IMPALA-9687 Improve estimates for number of hosts in Kudu plans
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e341597e980fb6a7e3792905b942ddf5797d03
Gerrit-Change-Number: 16880
Gerrit-PatchSet: 4
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 23:07:57 +0000
Gerrit-HasComments: No