You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2018/04/11 17:53:01 UTC
kudu git commit: Add hms_client-test to the IWYU filter
Repository: kudu
Updated Branches:
refs/heads/master 03d1fcb14 -> c09a62961
Add hms_client-test to the IWYU filter
This is in keeping with the other HMS files that trigger many false
positives on the upstream gerrit. I've verified that the file does pass
IWYU on a local instance.
Change-Id: Icb281ec42ea2f7dafe2a3cf91a4e3a3d9ba5150b
Reviewed-on: http://gerrit.cloudera.org:8080/9991
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/c09a6296
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/c09a6296
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/c09a6296
Branch: refs/heads/master
Commit: c09a6296181ecbb7d91687536f70fdbaac9fff5e
Parents: 03d1fcb
Author: Dan Burkert <da...@apache.org>
Authored: Wed Apr 11 09:31:38 2018 -0700
Committer: Dan Burkert <da...@apache.org>
Committed: Wed Apr 11 17:52:09 2018 +0000
----------------------------------------------------------------------
build-support/iwyu/iwyu-filter.awk | 1 +
src/kudu/hms/hms_client-test.cc | 12 ++++++------
2 files changed, 7 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/c09a6296/build-support/iwyu/iwyu-filter.awk
----------------------------------------------------------------------
diff --git a/build-support/iwyu/iwyu-filter.awk b/build-support/iwyu/iwyu-filter.awk
index 42f747f..0bd1034 100644
--- a/build-support/iwyu/iwyu-filter.awk
+++ b/build-support/iwyu/iwyu-filter.awk
@@ -92,6 +92,7 @@ BEGIN {
muted["kudu/experiments/rwlock-perf.cc"]
muted["kudu/hms/hms_catalog.cc"]
muted["kudu/hms/hms_catalog.h"]
+ muted["kudu/hms/hms_client-test.cc"]
muted["kudu/hms/hms_client.cc"]
muted["kudu/hms/hms_client.h"]
muted["kudu/hms/mini_hms.h"]
http://git-wip-us.apache.org/repos/asf/kudu/blob/c09a6296/src/kudu/hms/hms_client-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/hms/hms_client-test.cc b/src/kudu/hms/hms_client-test.cc
index a4a6ffe..c308f90 100644
--- a/src/kudu/hms/hms_client-test.cc
+++ b/src/kudu/hms/hms_client-test.cc
@@ -17,18 +17,18 @@
#include "kudu/hms/hms_client.h"
-#include <algorithm> // IWYU pragma: keep
+#include <algorithm>
#include <cstdint>
-#include <map> // IWYU pragma: keep
-#include <memory> // IWYU pragma: keep
+#include <map>
+#include <memory>
#include <string>
-#include <type_traits> // IWYU pragma: keep
+#include <type_traits>
#include <utility>
#include <vector>
-#include <boost/none_t.hpp> // IWYU pragma: keep
+#include <boost/none_t.hpp>
#include <boost/optional/optional.hpp>
-#include <glog/stl_logging.h> // IWYU pragma: keep
+#include <glog/stl_logging.h>
#include <gtest/gtest.h>
#include "kudu/hms/hive_metastore_constants.h"