You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/06 06:14:10 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #668: testing/fstest: Add O_TRUNC flag in fstest_wrfile
xiaoxiang781216 opened a new pull request #668:
URL: https://github.com/apache/incubator-nuttx-apps/pull/668
## Summary
to avoid the interference from the lasting run
## Impact
fstest
## Testing
Pass fstest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #668: testing/fstest: Add O_TRUNC flag in fstest_wrfile
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #668:
URL: https://github.com/apache/incubator-nuttx-apps/pull/668#issuecomment-814286220
The problem is that the test forget to clean in the fail path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #668: testing/fstest: Add O_TRUNC flag in fstest_wrfile
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #668:
URL: https://github.com/apache/incubator-nuttx-apps/pull/668#issuecomment-814244800
@xiaoxiang781216 There is an unlink as part of the test, that should remove the file. From a testing perspective: Would it be better to report the existence of the file as an error or warning then truncate it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #668: testing/fstest: Add O_TRUNC flag in fstest_wrfile
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #668:
URL: https://github.com/apache/incubator-nuttx-apps/pull/668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org