You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/08/16 20:38:28 UTC
[GitHub] [systemds] atefeh-asayesh opened a new pull request #1365: Nbatches parameter
atefeh-asayesh opened a new pull request #1365:
URL: https://github.com/apache/systemds/pull/1365
In this PR we add freq=NBATCHES along with the optional parameter nbatches to extend paramserv builtin for NBATCH updates.
In this step, It has been implemented for both local (computeNBatches(dataSize, batchIter)) and federated parameter servers (computeWithNBatchUpdates in FederatedPSControlThread.java).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1365: Nbatches parameter
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1365:
URL: https://github.com/apache/systemds/pull/1365#issuecomment-917214608
Let's close this PR as it was merged with #1382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] atefeh-asayesh commented on pull request #1365: Nbatches parameter
Posted by GitBox <gi...@apache.org>.
atefeh-asayesh commented on pull request #1365:
URL: https://github.com/apache/systemds/pull/1365#issuecomment-899865720
Draft- Some small changes would be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1365: Nbatches parameter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1365:
URL: https://github.com/apache/systemds/pull/1365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1365: Nbatches parameter
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1365:
URL: https://github.com/apache/systemds/pull/1365#issuecomment-917210692
LGTM - thanks @atefeh-asayesh for the extension of the parameter server. During the merge I mode the following changes:
* Fixed the local paramserv worker which pulled and pushed at the same iteration (for all but the first), although it needs to push the iteration before it pulls a new model and then work with that for nbatches.
* Fixed the federated paramserv implementation which did not update the model correctly under modelAvg (last model update missing, and outside `computeGradientsForNBatches` the returned model was assumed as gradients in an additional model update). The related changes also simplified some duplicated code.
* Fixed the computation of `numSetsPerEpocNbatches` which due to integer division might have lost a few batches.
* Removed unused nbatch member variables and test methods, fixed test methods which used the constructor name
* Fixed the federated tests to use a longer wait time after the last worker to ensure everything is ready before the experiments start.
* Fixed some minor formatting issues and warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org