You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Shivaraju Gowda <sh...@cisco.com> on 2014/03/05 00:14:09 UTC
Review Request 18757: HIVE-6486 Support secure Subject.doAs() in HiveServer2
JDBC client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18757/
-----------------------------------------------------------
Review request for hive, Kevin Minder, Prasad Mujumdar, Thejas Nair, and Vaibhav Gumashta.
Bugs: HIVE-6486
https://issues.apache.org/jira/browse/HIVE-6486
Repository: hive
Description
-------
Support secure Subject.doAs() in HiveServer2 JDBC client.
Original review: https://reviews.apache.org/r/18464/
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1574208
http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java 1574208
http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/TSubjectAssumingTransport.java PRE-CREATION
Diff: https://reviews.apache.org/r/18757/diff/
Testing
-------
Manual testing.
Thanks,
Shivaraju Gowda
Re: Review Request 18757: HIVE-6486 Support secure Subject.doAs() in
HiveServer2 JDBC client
Posted by Shivaraju Gowda <sh...@cisco.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18757/
-----------------------------------------------------------
(Updated March 5, 2014, 10:30 a.m.)
Review request for hive, Kevin Minder, Prasad Mujumdar, Thejas Nair, and Vaibhav Gumashta.
Changes
-------
change flag to kerberosAuthType=fromKeyTab and take care of indentation in KerberosSaslHelper.
Bugs: HIVE-6486
https://issues.apache.org/jira/browse/HIVE-6486
Repository: hive
Description
-------
Support secure Subject.doAs() in HiveServer2 JDBC client.
Original review: https://reviews.apache.org/r/18464/
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1574208
http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java 1574208
http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/TSubjectAssumingTransport.java PRE-CREATION
Diff: https://reviews.apache.org/r/18757/diff/
Testing
-------
Manual testing.
Thanks,
Shivaraju Gowda
Re: Review Request 18757: HIVE-6486 Support secure Subject.doAs() in
HiveServer2 JDBC client
Posted by Shivaraju Gowda <sh...@cisco.com>.
> On March 4, 2014, 11:16 p.m., Thejas Nair wrote:
> > http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java, line 70
> > <https://reviews.apache.org/r/18757/diff/1/?file=510309#file510309line70>
> >
> > can you take fix this indentation ? is it having tabs instead of spaces ?
> >
Yes there is a tab in there, both(this and the one below) of these blocks are eclipse indented(cntrl+i). However, the rest of the code has different indentation so it looks little odd. I will have to indent the entire file to be consistent.
- Shivaraju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18757/#review36205
-----------------------------------------------------------
On March 4, 2014, 3:14 p.m., Shivaraju Gowda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18757/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 3:14 p.m.)
>
>
> Review request for hive, Kevin Minder, Prasad Mujumdar, Thejas Nair, and Vaibhav Gumashta.
>
>
> Bugs: HIVE-6486
> https://issues.apache.org/jira/browse/HIVE-6486
>
>
> Repository: hive
>
>
> Description
> -------
>
> Support secure Subject.doAs() in HiveServer2 JDBC client.
>
> Original review: https://reviews.apache.org/r/18464/
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1574208
> http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java 1574208
> http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/TSubjectAssumingTransport.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18757/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
>
> Thanks,
>
> Shivaraju Gowda
>
>
Re: Review Request 18757: HIVE-6486 Support secure Subject.doAs() in
HiveServer2 JDBC client
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18757/#review36205
-----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java
<https://reviews.apache.org/r/18757/#comment67145>
can you take fix this indentation ? is it having tabs instead of spaces ?
http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java
<https://reviews.apache.org/r/18757/#comment67146>
The indentation here is also off.
- Thejas Nair
On March 4, 2014, 11:14 p.m., Shivaraju Gowda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18757/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 11:14 p.m.)
>
>
> Review request for hive, Kevin Minder, Prasad Mujumdar, Thejas Nair, and Vaibhav Gumashta.
>
>
> Bugs: HIVE-6486
> https://issues.apache.org/jira/browse/HIVE-6486
>
>
> Repository: hive
>
>
> Description
> -------
>
> Support secure Subject.doAs() in HiveServer2 JDBC client.
>
> Original review: https://reviews.apache.org/r/18464/
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1574208
> http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java 1574208
> http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/TSubjectAssumingTransport.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18757/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
>
> Thanks,
>
> Shivaraju Gowda
>
>