You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/02 08:00:47 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29623: [SPARK-32776] Limit in streaming should not be optimized away by PropagateEmptyRelation

HyukjinKwon commented on a change in pull request #29623:
URL: https://github.com/apache/spark/pull/29623#discussion_r481858247



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelationSuite.scala
##########
@@ -257,4 +257,10 @@ class PropagateEmptyRelationSuite extends PlanTest {
     val optimized = Optimize.execute(query.analyze)
     assert(optimized.resolved)
   }
+
+  test("should not optimize away limit if streaming") {

Review comment:
       shall we add a JIRA prefix? `test("SPARK-32776: should not optimize away limit if streaming") {`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org