[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890002#comment-15890002 ] 

ASF GitHub Bot commented on FLINK-5870:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3376#discussion_r103662852
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/RestUtils.java ---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.runtime.webmonitor.utils;
    +
    +public class RestUtils {
    --- End diff --
    
    I'm removing it.


> Make handlers aware of their REST URLs
> --------------------------------------
>
>                 Key: FLINK-5870
>                 URL: https://issues.apache.org/jira/browse/FLINK-5870
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.3.0
>
>
> The handlers in the WebRuntimeMonitor are currently unaware of the actual REST URL used. The handlers are simply registered under a given URL, without any guarantee that the handler can actually deal with that URL.
> I propose to let handlers themselves specify under which URL's they are supposed to be reachable. This provides are tighter coupling between URL and handler.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)