You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/17 01:29:21 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #4252: fix conflict and UT, cleanup redundant legacy code
jackwener opened a new pull request, #4252:
URL: https://github.com/apache/arrow-datafusion/pull/4252
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Related #4250
There is a logical conflict in https://github.com/apache/arrow-datafusion/pull/4192 and https://github.com/apache/arrow-datafusion/pull/4212
Without this fix master branch is broken: https://github.com/apache/arrow-datafusion/actions/runs/3483339533/jobs/5826711615
# Rationale for this change
remove unused union alias
# What changes are included in this PR?
- fix conflict
- fix UT
- followup[remove unused union alias]: cleanup redundant legacy code
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4252: fix conflict and UT, cleanup redundant legacy code
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4252:
URL: https://github.com/apache/arrow-datafusion/pull/4252#issuecomment-1318094382
Benchmark runs are scheduled for baseline = f4996b9f475b04bd260221f2a2bb074ab09b96be and contender = 7a81e9fb5382612c75bee0b4c46494a20e9fd7da. 7a81e9fb5382612c75bee0b4c46494a20e9fd7da is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e0ed9f0057df431fa696e4a96ce8ffe1...d014563368df490dbb78d0b747d83452/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f3d452829bb245ca8c44199c9da3c1c5...74097c0157c547f6a7af46f643507837/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/14751f7f21f74cdb83d2ffa3017f58eb...cd5cba743b15426e9f4b79df80331280/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9740f526e5d34368b7ed0909f9b8b38d...bd7708b9887b41ca87e24e7400600448/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang merged pull request #4252: fix conflict and UT, cleanup redundant legacy code
Posted by GitBox <gi...@apache.org>.
Ted-Jiang merged PR #4252:
URL: https://github.com/apache/arrow-datafusion/pull/4252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org