You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/06/16 22:23:01 UTC

[commons-vfs] branch master updated: VFS-619 Fixes performance issue with SftpFileObject.getChildren() (#65)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git


The following commit(s) were added to refs/heads/master by this push:
     new af4ee73  VFS-619 Fixes performance issue with SftpFileObject.getChildren() (#65)
af4ee73 is described below

commit af4ee73bc2afdb76d7aedc8f2ceeb3eee9c2813b
Author: David Septimus <Da...@users.noreply.github.com>
AuthorDate: Sun Jun 16 18:22:57 2019 -0400

    VFS-619 Fixes performance issue with SftpFileObject.getChildren() (#65)
    
    * VFS-619 Fixes performance issue with SftpFileObject.getChildren() due to refresh() making a stat call to the SFTP server.
    
    * VFS-619 Removes redundant implementation of FileObject.refresh()
---
 .../commons/vfs2/provider/sftp/SftpFileObject.java | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
index 6edfa96..3a65ed4 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
@@ -68,28 +68,6 @@ public class SftpFileObject extends AbstractFileObject<SftpFileSystem> {
     }
 
     /**
-     * @throws FileSystemException if error occurs.
-     * @since 2.0
-     */
-    @Override
-    public void refresh() throws FileSystemException {
-        if (!inRefresh) {
-            try {
-                inRefresh = true;
-                super.refresh();
-                try {
-                    attrs = null;
-                    getType();
-                } catch (final IOException e) {
-                    throw new FileSystemException(e);
-                }
-            } finally {
-                inRefresh = false;
-            }
-        }
-    }
-
-    /**
      * Determines the type of this file, returns null if the file does not exist.
      */
     @Override