You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/24 03:30:51 UTC
[GitHub] [pulsar] Jason918 commented on a change in pull request #12874: [broker] Optimize blocking backlogQuotaCheck to non-blocking in ServerCnx#handleProducer
Jason918 commented on a change in pull request #12874:
URL: https://github.com/apache/pulsar/pull/12874#discussion_r755675993
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1189,65 +1190,70 @@ protected void handleProducer(final CommandProducer cmdProducer) {
service.getOrCreateTopic(topicName.toString()).thenAccept((Topic topic) -> {
// Before creating producer, check if backlog quota exceeded
// on topic for size based limit and time based limit
- for (BacklogQuota.BacklogQuotaType backlogQuotaType : BacklogQuota.BacklogQuotaType.values()) {
- if (topic.isBacklogQuotaExceeded(producerName, backlogQuotaType)) {
- IllegalStateException illegalStateException = new IllegalStateException(
- "Cannot create producer on topic with backlog quota exceeded");
- BacklogQuota.RetentionPolicy retentionPolicy = topic
- .getBacklogQuota(backlogQuotaType).getPolicy();
- if (retentionPolicy == BacklogQuota.RetentionPolicy.producer_request_hold) {
- commandSender.sendErrorResponse(requestId,
- ServerError.ProducerBlockedQuotaExceededError,
- illegalStateException.getMessage());
- } else if (retentionPolicy == BacklogQuota.RetentionPolicy.producer_exception) {
- commandSender.sendErrorResponse(requestId,
- ServerError.ProducerBlockedQuotaExceededException,
- illegalStateException.getMessage());
- }
- producerFuture.completeExceptionally(illegalStateException);
- producers.remove(producerId, producerFuture);
- return;
+ CompletableFuture<Void> backlogQuotaCheckFuture = CompletableFuture.allOf(
+ topic.checkBacklogQuotaExceeded(producerName, BacklogQuotaType.destination_storage),
+ topic.checkBacklogQuotaExceeded(producerName, BacklogQuotaType.message_age));
+ backlogQuotaCheckFuture.exceptionally(throwable -> {
+ //throwable should be CompletionException holding TopicBacklogQuotaExceededException
+ BrokerServiceException.TopicBacklogQuotaExceededException exception =
Review comment:
Two situations:
1. If `preciseTimeBasedBacklogQuotaCheck` set as true (default is false) and some other constrains met, this will be execute in the callback thread of `ManagedLedgerImpl#asyncReadEntry(...)`.
2. Otherwise everything is executed in previous thread. Nothing async.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org