You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2017/04/21 03:02:29 UTC

[GitHub] beam pull request #2625: Coder.structuralValue(T) should never throw

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2625

    Coder.structuralValue(T) should never throw

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    In the worst case, encoding to a byte array should never fail due to IO.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam coder_structural_values_never_throws

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2625.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2625
    
----
commit 4915efe8be7b9a2a4cbfe83449e23132e658ac41
Author: Thomas Groh <tg...@google.com>
Date:   2017-04-21T03:00:07Z

    Coder.structuralValue(T) should never throw
    
    In the worst case, encoding to a byte array should never fail due to IO.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2625: Coder.structuralValue(T) should never throw

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2625


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---