You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/17 15:54:29 UTC

[GitHub] [tvm-rfcs] tqchen edited a comment on pull request #23: [RFC][TIR] TIR Pinned Memory Representation

tqchen edited a comment on pull request #23:
URL: https://github.com/apache/tvm-rfcs/pull/23#issuecomment-921900930


   Thanks @manupa-arm , sorry for the delay. I think the proposal(of adding annotations) looks good. 
   
   As a formal procedure for IR change. It would be great to have an RFC(or change this RFC) to "Adding annotation field to allocation" and discuss the need of pinned memory as a usecase.
   
   As for the annotation field itself, it would be great to follow the documentation of ForNode here https://github.com/apache/tvm/blob/main/include/tvm/tir/stmt.h#L817 that states the annotation only served as a hint for optimizations and does not change the semantics of the allocate.
   
   After the annotations field is added. The design choice of pinned memory can then becomes a specific choice of USMP and can be merged with USMP RFC.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org